Skip to content
Permalink
Browse files
Rename WebCore/editing/visible_units.* to VisibleUnits.*
https://bugs.webkit.org/show_bug.cgi?id=111426

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests. Just a refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityNodeObject.cpp:
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* dom/Position.cpp:
* dom/Range.cpp:
* editing/AlternativeTextController.cpp:
* editing/ApplyBlockElementCommand.cpp:
* editing/ApplyStyleCommand.cpp:
* editing/CompositeEditCommand.cpp:
* editing/DeleteSelectionCommand.cpp:
* editing/EditingAllInOne.cpp:
* editing/EditingStyle.cpp:
* editing/Editor.cpp:
* editing/FormatBlockCommand.cpp:
* editing/FrameSelection.cpp:
* editing/IndentOutdentCommand.cpp:
* editing/InsertLineBreakCommand.cpp:
* editing/InsertListCommand.cpp:
* editing/InsertParagraphSeparatorCommand.cpp:
* editing/InsertTextCommand.cpp:
* editing/ReplaceSelectionCommand.cpp:
* editing/SurroundingText.cpp:
* editing/TextCheckingHelper.cpp:
* editing/TextIterator.cpp:
* editing/TypingCommand.cpp:
* editing/VisiblePosition.cpp:
* editing/VisibleSelection.cpp:
* editing/VisibleUnits.cpp: Copied from Source/WebCore/editing/visible_units.cpp.
* editing/VisibleUnits.h: Copied from Source/WebCore/editing/visible_units.h.
* editing/htmlediting.cpp:
* editing/markup.cpp:
* editing/visible_units.cpp: Removed.
* editing/visible_units.h: Removed.
* page/Frame.cpp:
* page/mac/FrameMac.mm:
* platform/win/EditorWin.cpp:

Source/WebKit/mac:

* WebView/WebFrame.mm:

Source/WebKit2:

* WebProcess/WebPage/mac/WebPageMac.mm:


Canonical link: https://commits.webkit.org/129927@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
tkent-google committed Mar 6, 2013
1 parent 5e6918e commit 5b35e2431646aa77db8c40b426ea7f0cb0a405de
Showing 50 changed files with 145 additions and 70 deletions.
@@ -1326,10 +1326,10 @@ set(WebCore_SOURCES
editing/UnlinkCommand.cpp
editing/VisiblePosition.cpp
editing/VisibleSelection.cpp
editing/VisibleUnits.cpp
editing/WrapContentsInDummySpanCommand.cpp
editing/htmlediting.cpp
editing/markup.cpp
editing/visible_units.cpp

fileapi/AsyncFileStream.cpp
fileapi/Blob.cpp
@@ -1,3 +1,60 @@
2013-03-05 Kent Tamura <tkent@chromium.org>

Rename WebCore/editing/visible_units.* to VisibleUnits.*
https://bugs.webkit.org/show_bug.cgi?id=111426

Reviewed by Alexey Proskuryakov.

No new tests. Just a refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityNodeObject.cpp:
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* dom/Position.cpp:
* dom/Range.cpp:
* editing/AlternativeTextController.cpp:
* editing/ApplyBlockElementCommand.cpp:
* editing/ApplyStyleCommand.cpp:
* editing/CompositeEditCommand.cpp:
* editing/DeleteSelectionCommand.cpp:
* editing/EditingAllInOne.cpp:
* editing/EditingStyle.cpp:
* editing/Editor.cpp:
* editing/FormatBlockCommand.cpp:
* editing/FrameSelection.cpp:
* editing/IndentOutdentCommand.cpp:
* editing/InsertLineBreakCommand.cpp:
* editing/InsertListCommand.cpp:
* editing/InsertParagraphSeparatorCommand.cpp:
* editing/InsertTextCommand.cpp:
* editing/ReplaceSelectionCommand.cpp:
* editing/SurroundingText.cpp:
* editing/TextCheckingHelper.cpp:
* editing/TextIterator.cpp:
* editing/TypingCommand.cpp:
* editing/VisiblePosition.cpp:
* editing/VisibleSelection.cpp:
* editing/VisibleUnits.cpp: Copied from Source/WebCore/editing/visible_units.cpp.
* editing/VisibleUnits.h: Copied from Source/WebCore/editing/visible_units.h.
* editing/htmlediting.cpp:
* editing/markup.cpp:
* editing/visible_units.cpp: Removed.
* editing/visible_units.h: Removed.
* page/Frame.cpp:
* page/mac/FrameMac.mm:
* platform/win/EditorWin.cpp:

2013-03-06 Alexis Menard <alexis@webkit.org>

Do not add CSSPropertyBorderImage shorthand part of the property list when parsing CSS border property
@@ -3202,8 +3202,8 @@ webcore_sources += \
Source/WebCore/editing/VisiblePosition.h \
Source/WebCore/editing/VisibleSelection.cpp \
Source/WebCore/editing/VisibleSelection.h \
Source/WebCore/editing/visible_units.cpp \
Source/WebCore/editing/visible_units.h \
Source/WebCore/editing/VisibleUnits.cpp \
Source/WebCore/editing/VisibleUnits.h \
Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp \
Source/WebCore/editing/WrapContentsInDummySpanCommand.h \
Source/WebCore/editing/WritingDirection.h \
@@ -554,7 +554,7 @@ SOURCES += \
editing/UnlinkCommand.cpp \
editing/VisiblePosition.cpp \
editing/VisibleSelection.cpp \
editing/visible_units.cpp \
editing/VisibleUnits.cpp \
editing/WrapContentsInDummySpanCommand.cpp \
fileapi/AsyncFileStream.cpp \
fileapi/AsyncFileStream.cpp \
@@ -1779,7 +1779,7 @@ HEADERS += \
editing/UnlinkCommand.h \
editing/VisiblePosition.h \
editing/VisibleSelection.h \
editing/visible_units.h \
editing/VisibleUnits.h \
editing/WrapContentsInDummySpanCommand.h \
fileapi/Blob.h \
fileapi/BlobURL.h \
@@ -1836,6 +1836,7 @@
'editing/UnlinkCommand.h',
'editing/VisiblePosition.cpp',
'editing/VisibleSelection.cpp',
'editing/VisibleUnits.cpp',
'editing/WrapContentsInDummySpanCommand.cpp',
'editing/WrapContentsInDummySpanCommand.h',
'editing/atk/FrameSelectionAtk.cpp',
@@ -1845,7 +1846,6 @@
'editing/mac/EditorMac.mm',
'editing/mac/FrameSelectionMac.mm',
'editing/markup.cpp',
'editing/visible_units.cpp',
'fileapi/AsyncFileStream.cpp',
'fileapi/AsyncFileStream.h',
'fileapi/Blob.cpp',
@@ -59803,7 +59803,7 @@
>
</File>
<File
RelativePath="..\editing\visible_units.cpp"
RelativePath="..\editing\VisiblePosition.cpp"
>
<FileConfiguration
Name="Debug|Win32"
@@ -59855,11 +59855,11 @@
</FileConfiguration>
</File>
<File
RelativePath="..\editing\visible_units.h"
RelativePath="..\editing\VisiblePosition.h"
>
</File>
<File
RelativePath="..\editing\VisiblePosition.cpp"
RelativePath="..\editing\VisibleSelection.cpp"
>
<FileConfiguration
Name="Debug|Win32"
@@ -59911,11 +59911,11 @@
</FileConfiguration>
</File>
<File
RelativePath="..\editing\VisiblePosition.h"
RelativePath="..\editing\VisibleSelection.h"
>
</File>
<File
RelativePath="..\editing\VisibleSelection.cpp"
RelativePath="..\editing\VisibleUnits.cpp"
>
<FileConfiguration
Name="Debug|Win32"
@@ -59967,7 +59967,7 @@
</FileConfiguration>
</File>
<File
RelativePath="..\editing\VisibleSelection.h"
RelativePath="..\editing\VisibleUnits.h"
>
</File>
<File
@@ -6344,19 +6344,19 @@
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
</ClCompile>
<ClCompile Include="..\editing\visible_units.cpp">
<ClCompile Include="..\editing\VisiblePosition.cpp">
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
</ClCompile>
<ClCompile Include="..\editing\VisiblePosition.cpp">
<ClCompile Include="..\editing\VisibleSelection.cpp">
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
</ClCompile>
<ClCompile Include="..\editing\VisibleSelection.cpp">
<ClCompile Include="..\editing\VisibleUnits.cpp">
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
@@ -10194,9 +10194,9 @@
<ClInclude Include="..\editing\TypingCommand.h" />
<ClInclude Include="..\editing\UndoStep.h" />
<ClInclude Include="..\editing\UnlinkCommand.h" />
<ClInclude Include="..\editing\visible_units.h" />
<ClInclude Include="..\editing\VisiblePosition.h" />
<ClInclude Include="..\editing\VisibleSelection.h" />
<ClInclude Include="..\editing\VisibleUnits.h" />
<ClInclude Include="..\editing\WrapContentsInDummySpanCommand.h" />
<ClInclude Include="..\fileapi\AsyncFileStream.h" />
<ClInclude Include="..\html\BaseButtonInputType.h" />
@@ -5136,15 +5136,15 @@
<ClCompile Include="..\editing\UnlinkCommand.cpp">
<Filter>editing</Filter>
</ClCompile>
<ClCompile Include="..\editing\visible_units.cpp">
<Filter>editing</Filter>
</ClCompile>
<ClCompile Include="..\editing\VisiblePosition.cpp">
<Filter>editing</Filter>
</ClCompile>
<ClCompile Include="..\editing\VisibleSelection.cpp">
<Filter>editing</Filter>
</ClCompile>
<ClCompile Include="..\editing\VisibleUnits.cpp">
<Filter>editing</Filter>
</ClCompile>
<ClCompile Include="..\editing\WrapContentsInDummySpanCommand.cpp">
<Filter>editing</Filter>
</ClCompile>
@@ -3293,8 +3293,8 @@
93309E1A099E64920056E581 /* TypingCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309DCB099E64910056E581 /* TypingCommand.h */; };
93309E1B099E64920056E581 /* TextIterator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309DCC099E64910056E581 /* TextIterator.cpp */; };
93309E1C099E64920056E581 /* TextIterator.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309DCD099E64910056E581 /* TextIterator.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309E1D099E64920056E581 /* visible_units.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309DCE099E64910056E581 /* visible_units.cpp */; };
93309E1E099E64920056E581 /* visible_units.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309DCF099E64910056E581 /* visible_units.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309E1D099E64920056E581 /* VisibleUnits.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309DCE099E64910056E581 /* VisibleUnits.cpp */; };
93309E1E099E64920056E581 /* VisibleUnits.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309DCF099E64910056E581 /* VisibleUnits.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309E1F099E64920056E581 /* VisiblePosition.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309DD0099E64910056E581 /* VisiblePosition.cpp */; };
93309E20099E64920056E581 /* VisiblePosition.h in Headers */ = {isa = PBXBuildFile; fileRef = 93309DD1099E64910056E581 /* VisiblePosition.h */; settings = {ATTRIBUTES = (Private, ); }; };
93309E23099E64920056E581 /* WrapContentsInDummySpanCommand.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93309DD4099E64910056E581 /* WrapContentsInDummySpanCommand.cpp */; };
@@ -10760,8 +10760,8 @@
93309DCB099E64910056E581 /* TypingCommand.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TypingCommand.h; sourceTree = "<group>"; };
93309DCC099E64910056E581 /* TextIterator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TextIterator.cpp; sourceTree = "<group>"; };
93309DCD099E64910056E581 /* TextIterator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextIterator.h; sourceTree = "<group>"; };
93309DCE099E64910056E581 /* visible_units.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = visible_units.cpp; sourceTree = "<group>"; };
93309DCF099E64910056E581 /* visible_units.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = visible_units.h; sourceTree = "<group>"; };
93309DCE099E64910056E581 /* VisibleUnits.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = VisibleUnits.cpp; sourceTree = "<group>"; };
93309DCF099E64910056E581 /* VisibleUnits.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = VisibleUnits.h; sourceTree = "<group>"; };
93309DD0099E64910056E581 /* VisiblePosition.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = VisiblePosition.cpp; sourceTree = "<group>"; };
93309DD1099E64910056E581 /* VisiblePosition.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = VisiblePosition.h; sourceTree = "<group>"; };
93309DD4099E64910056E581 /* WrapContentsInDummySpanCommand.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WrapContentsInDummySpanCommand.cpp; sourceTree = "<group>"; };
@@ -17933,12 +17933,12 @@
9B2D8A7814997CCF00ECEF3E /* UndoStep.h */,
D086FE9709D53AAB005BC74D /* UnlinkCommand.cpp */,
D086FE9609D53AAB005BC74D /* UnlinkCommand.h */,
93309DCE099E64910056E581 /* visible_units.cpp */,
93309DCF099E64910056E581 /* visible_units.h */,
93309DD0099E64910056E581 /* VisiblePosition.cpp */,
93309DD1099E64910056E581 /* VisiblePosition.h */,
A883DF250F3D045D00F19BF6 /* VisibleSelection.cpp */,
A883DF260F3D045D00F19BF6 /* VisibleSelection.h */,
93309DCE099E64910056E581 /* VisibleUnits.cpp */,
93309DCF099E64910056E581 /* VisibleUnits.h */,
93309DD4099E64910056E581 /* WrapContentsInDummySpanCommand.cpp */,
93309DD5099E64910056E581 /* WrapContentsInDummySpanCommand.h */,
9BAF3B2312C1A39800014BF1 /* WritingDirection.h */,
@@ -26504,9 +26504,9 @@
BCA257151293C010007A263D /* VerticalPositionCache.h in Headers */,
CEF418CF1179678C009D112C /* ViewportArguments.h in Headers */,
3FFFF9AE159D9B060020BBD5 /* ViewportStyleResolver.h in Headers */,
93309E1E099E64920056E581 /* visible_units.h in Headers */,
93309E20099E64920056E581 /* VisiblePosition.h in Headers */,
A883DF280F3D045D00F19BF6 /* VisibleSelection.h in Headers */,
93309E1E099E64920056E581 /* VisibleUnits.h in Headers */,
29A309B11561CAC400BBD8E5 /* VisitedLinks.h in Headers */,
419BC2DF1685329900D64D6D /* VisitedLinkState.h in Headers */,
515788C11207852C00A37C4A /* VisitedLinkStrategy.h in Headers */,
@@ -29723,9 +29723,9 @@
FD3160AE12B026F700C1A359 /* VectorMath.cpp in Sources */,
CEF418CE1179678C009D112C /* ViewportArguments.cpp in Sources */,
3FFFF9AD159D9B060020BBD5 /* ViewportStyleResolver.cpp in Sources */,
93309E1D099E64920056E581 /* visible_units.cpp in Sources */,
93309E1F099E64920056E581 /* VisiblePosition.cpp in Sources */,
A883DF270F3D045D00F19BF6 /* VisibleSelection.cpp in Sources */,
93309E1D099E64920056E581 /* VisibleUnits.cpp in Sources */,
29A309B01561CAC400BBD8E5 /* VisitedLinks.cpp in Sources */,
419BC2DE1685329900D64D6D /* VisitedLinkState.cpp in Sources */,
FD7F299113D4C0CB00AD9535 /* WaveShaperDSPKernel.cpp in Sources */,
@@ -70,9 +70,9 @@
#include "TextControlInnerElements.h"
#include "TextIterator.h"
#include "UserGestureIndicator.h"
#include "VisibleUnits.h"
#include "Widget.h"
#include "htmlediting.h"
#include "visible_units.h"
#include <wtf/StdLibExtras.h>
#include <wtf/text/StringBuilder.h>
#include <wtf/unicode/CharacterNames.h>
@@ -57,8 +57,8 @@
#include "TextCheckingHelper.h"
#include "TextIterator.h"
#include "UserGestureIndicator.h"
#include "VisibleUnits.h"
#include "htmlediting.h"
#include "visible_units.h"
#include <wtf/StdLibExtras.h>
#include <wtf/text/StringBuilder.h>
#include <wtf/text/WTFString.h>
@@ -90,8 +90,8 @@
#include "SVGSVGElement.h"
#include "Text.h"
#include "TextControlInnerElements.h"
#include "VisibleUnits.h"
#include "htmlediting.h"
#include "visible_units.h"
#include <wtf/StdLibExtras.h>
#include <wtf/text/StringBuilder.h>
#include <wtf/unicode/CharacterNames.h>
@@ -44,6 +44,7 @@
#include "RenderObject.h"
#include "Settings.h"
#include "TextIterator.h"
#include "VisibleUnits.h"
#include "WebKitAccessibleHyperlink.h"
#include "WebKitAccessibleInterfaceAction.h"
#include "WebKitAccessibleInterfaceComponent.h"
@@ -58,7 +59,6 @@
#include "WebKitAccessibleInterfaceValue.h"
#include "WebKitAccessibleUtil.h"
#include "htmlediting.h"
#include "visible_units.h"
#include <glib/gprintf.h>

#if PLATFORM(GTK)
@@ -67,11 +67,11 @@
#import "TextCheckerClient.h"
#import "TextCheckingHelper.h"
#import "TextIterator.h"
#import "VisibleUnits.h"
#import "WebCoreFrameView.h"
#import "WebCoreObjCExtras.h"
#import "WebCoreSystemInterface.h"
#import "htmlediting.h"
#import "visible_units.h"

using namespace WebCore;
using namespace HTMLNames;
@@ -67,11 +67,11 @@
#import "TextCheckerClient.h"
#import "TextCheckingHelper.h"
#import "TextIterator.h"
#import "VisibleUnits.h"
#import "WebCoreFrameView.h"
#import "WebCoreObjCExtras.h"
#import "WebCoreSystemInterface.h"
#import "htmlediting.h"
#import "visible_units.h"

using namespace WebCore;
using namespace HTMLNames;
@@ -39,8 +39,8 @@
#include "Text.h"
#include "TextIterator.h"
#include "VisiblePosition.h"
#include "VisibleUnits.h"
#include "htmlediting.h"
#include "visible_units.h"
#include <stdio.h>
#include <wtf/text/CString.h>
#include <wtf/unicode/CharacterNames.h>
@@ -45,9 +45,9 @@
#include "Text.h"
#include "TextIterator.h"
#include "VisiblePosition.h"
#include "VisibleUnits.h"
#include "htmlediting.h"
#include "markup.h"
#include "visible_units.h"
#include <stdio.h>
#include <wtf/RefCountedLeakCounter.h>
#include <wtf/Vector.h>
@@ -44,9 +44,9 @@
#include "TextEvent.h"
#include "TextIterator.h"
#include "VisibleSelection.h"
#include "VisibleUnits.h"
#include "htmlediting.h"
#include "markup.h"
#include "visible_units.h"

namespace WebCore {

@@ -34,8 +34,8 @@
#include "Text.h"
#include "TextIterator.h"
#include "VisiblePosition.h"
#include "VisibleUnits.h"
#include "htmlediting.h"
#include "visible_units.h"

namespace WebCore {

0 comments on commit 5b35e24

Please sign in to comment.