Skip to content
Permalink
Browse files
REGRESSION(r288644): [GTK4] Criticals when using pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=235883

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseZoomBegin):
Only cancel the click gesture on GTK3. We don't use g_object_set_data() on GTK4.



Canonical link: https://commits.webkit.org/246585@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Exalm committed Jan 31, 2022
1 parent 4019bc2 commit 5b5aac2e0b8310b59bbc8ee756e9c787578b01a5
Showing 2 changed files with 13 additions and 0 deletions.
@@ -1,3 +1,14 @@
2022-01-31 Alexander Mikhaylenko <alexm@gnome.org>

REGRESSION(r288644): [GTK4] Criticals when using pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=235883

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseZoomBegin):
Only cancel the click gesture on GTK3. We don't use g_object_set_data() on GTK4.

2022-01-30 Ryosuke Niwa <rniwa@webkit.org>

Delete code for keygen element
@@ -1884,8 +1884,10 @@ static void webkitWebViewBaseZoomBegin(WebKitWebViewBase* webViewBase, GdkEventS

webkitWebViewBaseSynthesizeWheelEvent(webViewBase, event, 0, 0, x, y, WheelEventPhase::Began, WheelEventPhase::NoPhase, true);

#if !USE(GTK4)
GtkGesture* click = GTK_GESTURE(g_object_get_data(G_OBJECT(webViewBase), "wk-view-multi-press-gesture"));
gtk_gesture_set_state(click, GTK_EVENT_SEQUENCE_DENIED);
#endif
}

static void webkitWebViewBaseZoomChanged(WebKitWebViewBase* webViewBase, gdouble scale, GtkGesture* gesture)

0 comments on commit 5b5aac2

Please sign in to comment.