Skip to content
Permalink
Browse files
<http://webkit.org/b/60710> JavaScriptGlue should compile with -Wmiss…
…ing-prototypes

Reviewed by Geoffrey Garen.

Enabling -Wmissing-prototypes fixes an Xcode 4 project warning.

This also fixes the following compiler warning:

    JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function 'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3]
     JSGlobalData* getThreadGlobalData()
                   ^

* Configurations/Base.xcconfig: Set
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES.
* JSUtils.cpp:
(getThreadGlobalData): Made static.

Canonical link: https://commits.webkit.org/76052@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ddkilzer committed May 12, 2011
1 parent 870e2a6 commit 5d5d3bd072fbf1245fc3c60131bee5c7f076cfa5
Showing 3 changed files with 21 additions and 2 deletions.
@@ -1,3 +1,22 @@
2011-05-12 David Kilzer <ddkilzer@apple.com>

<http://webkit.org/b/60710> JavaScriptGlue should compile with -Wmissing-prototypes

Reviewed by Geoffrey Garen.

Enabling -Wmissing-prototypes fixes an Xcode 4 project warning.

This also fixes the following compiler warning:

JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function 'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3]
JSGlobalData* getThreadGlobalData()
^

* Configurations/Base.xcconfig: Set
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES.
* JSUtils.cpp:
(getThreadGlobalData): Made static.

2011-05-06 David Kilzer <ddkilzer@apple.com>

Remove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings
@@ -42,7 +42,7 @@ GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = NO;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
LINKER_DISPLAYS_MANGLED_NAMES = YES;
PREBINDING = NO;
@@ -404,7 +404,7 @@ static void initializeGlobalObjectKey()
pthread_key_create(&globalObjectKey, unprotectGlobalObject);
}

JSGlobalData* getThreadGlobalData()
static JSGlobalData* getThreadGlobalData()
{
return &JSGlobalData::sharedInstance();
}

0 comments on commit 5d5d3bd

Please sign in to comment.