Don't trigger Windows builds for changes to WebCore.exp.in or the top…

…-level GNUmakefile.am

Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
but did

Reviewed by Anders Carlsson.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added some more tests.

Canonical link: https://commits.webkit.org/69481@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog

@@ -1,3 +1,19 @@
+2011-02-24  Adam Roben  <aroben@apple.com>
+
+        Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
+
+        Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
+        but did
+
+        Reviewed by Anders Carlsson.
+
+        * Scripts/webkitpy/common/config/build.py:
+        (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
+        top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
+
+        * Scripts/webkitpy/common/config/build_unittest.py:
+        (ShouldBuildTest): Added some more tests.
+
 2011-02-24  Andras Becsi  <abecsi@webkit.org>
 
         Reviewed by Laszlo Gombos.

Tools/Scripts/webkitpy/common/config/build.py

@@ -94,10 +94,10 @@ def _should_file_trigger_build(target_platform, file):
         (r"\.(?:bkl|mk)$", []),
 
         # Patterns that should trigger builds on only some bots.
-        (r"/GNUmakefile\.am$", ["gtk"]),
+        (r"(?:^|/)GNUmakefile\.am$", ["gtk"]),
         (r"/\w+Chromium\w*\.(?:cpp|h|mm)$", ["chromium"]),
         (r"Mac\.(?:cpp|h|mm)$", ["mac"]),
-        (r"\.exp$", ["mac"]),
+        (r"\.exp(?:\.in)?$", ["mac"]),
         (r"\.gypi?", ["chromium"]),
         (r"\.order$", ["mac"]),
         (r"\.pr[io]$", ["qt"]),

Tools/Scripts/webkitpy/common/config/build_unittest.py

@@ -28,12 +28,14 @@
 class ShouldBuildTest(unittest.TestCase):
     _should_build_tests = [
         (["ChangeLog", "Source/WebCore/ChangeLog", "Source/WebKit2/ChangeLog-2011-02-11"], []),
+        (["GNUmakefile.am", "Source/WebCore/GNUmakefile.am"], ["gtk"]),
         (["Websites/bugs.webkit.org/foo", "Source/WebCore/bar"], ["*"]),
         (["Websites/bugs.webkit.org/foo"], []),
         (["Source/JavaScriptCore/JavaScriptCore.xcodeproj/foo"], ["mac-leopard", "mac-snowleopard"]),
         (["Source/JavaScriptGlue/foo", "Source/WebCore/bar"], ["*"]),
         (["Source/JavaScriptGlue/foo"], ["mac-leopard", "mac-snowleopard"]),
         (["LayoutTests/foo"], ["*"]),
+        (["LayoutTests/canvas/philip/tests/size.attributes.parse.exp-expected.txt", "LayoutTests/canvas/philip/tests/size.attributes.parse.exp.html"], ["*"]),
         (["LayoutTests/platform/chromium-linux/foo"], ["chromium-linux"]),
         (["LayoutTests/platform/chromium-win/fast/compact/001-expected.txt"], ["chromium-win"]),
         (["LayoutTests/platform/mac-leopard/foo"], ["mac-leopard"]),
@@ -43,6 +45,7 @@ class ShouldBuildTest(unittest.TestCase):
         (["LayoutTests/platform/win-xp/foo"], ["win"]),
         (["LayoutTests/platform/win-wk2/foo"], ["win"]),
         (["LayoutTests/platform/win/foo"], ["win"]),
+        (["Source/WebCore.exp.in", "Source/WebKit/mac/WebKit.exp"], ["mac"]),
         (["Source/WebCore/mac/foo"], ["chromium-mac", "mac-leopard", "mac-snowleopard"]),
         (["Source/WebCore/win/foo"], ["chromium-win", "win"]),
         (["Source/WebCore/platform/graphics/gpu/foo"], ["mac-leopard", "mac-snowleopard"]),