Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[JSC] Disable import-assertion since TC39 decides bringing it back to…
… stage-2

https://bugs.webkit.org/show_bug.cgi?id=251600
rdar://104964116

Reviewed by Michael Saboff.

We found that the current syntax & semantics do not work with CSS / JSON module integration in HTML side,
and it requires drastic changes in import-assertion in both syntax and semantics levels, which means that
the current proposal becomes obsolete / not-shippable state. TC39 discussed about this and decided to
bring import-assertion down to stage-2 from stage-3 to announce that this is not shippable state right now.
This patch disables import-assertion by flipping a runtime flag.

* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/259795@main
  • Loading branch information
Constellation committed Feb 3, 2023
1 parent d7a2a70 commit 5eb7887
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
18 changes: 15 additions & 3 deletions LayoutTests/TestExpectations
Expand Up @@ -475,9 +475,6 @@ imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-en
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy-attribute.https.sub.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-network-error.sub.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_allow_downloads.tentative.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/integrity.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/import-css-module-basic.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/integrity.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/user-activation/no-activation-thru-escape-key.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-event-during-parse.html [ DumpJSConsoleLogInStdErr ]
Expand Down Expand Up @@ -6207,3 +6204,18 @@ webkit.org/b/245905 imported/w3c/web-platform-tests/css/css-text/line-breaking/l
js/dom/Promise-reject-large-string.html [ DumpJSConsoleLogInStdErr ]

webkit.org/b/251624 fast/images/animated-heics-verify.html [ Skip ]

# Import-assertion gets reverted to stage-2.
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/content-type-checking.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/import-css-module-basic.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/integrity.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/load-error-events.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/import-assertions/empty-assertion-clause.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/import-assertions/invalid-type-assertion-error.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/import-assertions/unsupported-assertion.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/charset.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/integrity.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/json-module-service-worker-test.https.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/load-error-events.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/module.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.html [ Skip ]
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/runtime/OptionsList.h
Expand Up @@ -548,7 +548,7 @@ bool canUseWebAssemblyFastMemory();
v(Bool, useArrayFromAsync, true, Normal, "Expose the Array.fromAsync.") \
v(Bool, useArrayGroupMethod, true, Normal, "Expose the group() and groupToMap() methods on Array.") \
v(Bool, useAtomicsWaitAsync, true, Normal, "Expose the waitAsync() methods on Atomics.") \
v(Bool, useImportAssertion, true, Normal, "Enable import assertion.") \
v(Bool, useImportAssertion, false, Normal, "Enable import assertion.") \
v(Bool, useIntlDurationFormat, true, Normal, "Expose the Intl DurationFormat.") \
v(Bool, useResizableArrayBuffer, true, Normal, "Expose ResizableArrayBuffer feature.") \
v(Bool, useSharedArrayBuffer, false, Normal, nullptr) \
Expand Down

0 comments on commit 5eb7887

Please sign in to comment.