Skip to content
Permalink
Browse files
REGRESSION(r293608): [GTK][WPE] Broke clang builds
https://bugs.webkit.org/show_bug.cgi?id=239899

Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-29
Reviewed by Michael Catanzaro.

* wtf/StdLibExtras.h: Restrict std::remove_cvref hacks to GCC.

Canonical link: https://commits.webkit.org/250125@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
philn authored and webkit-commit-queue committed Apr 29, 2022
1 parent ac3662d commit 5fad2014e3ee7c2dd7bccfef9511839e2d1a8f04
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
@@ -1,3 +1,12 @@
2022-04-29 Philippe Normand <philn@igalia.com>

REGRESSION(r293608): [GTK][WPE] Broke clang builds
https://bugs.webkit.org/show_bug.cgi?id=239899

Reviewed by Michael Catanzaro.

* wtf/StdLibExtras.h: Restrict std::remove_cvref hacks to GCC.

2022-04-29 Diego Pino Garcia <dpino@igalia.com>

[GCC] std::remove_cvref is undefined in GCC8.4
@@ -606,7 +606,7 @@ template<typename OptionalType> auto valueOrDefault(OptionalType&& optionalValue
#define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)

// FIXME: Needed for GCC<=9.3. Remove it after Ubuntu 20.04 end of support (May 2023).
#if defined(__GLIBCXX__) && !defined(HAVE_STD_REMOVE_CVREF)
#if defined(__GLIBCXX__) && !defined(HAVE_STD_REMOVE_CVREF) && !COMPILER(CLANG)
namespace std {
template <typename T>
struct remove_cvref {

0 comments on commit 5fad201

Please sign in to comment.