Skip to content
Permalink
Browse files
Web Inspector: Do not show contextual documentation popup in the Chan…
…ges panel

https://bugs.webkit.org/show_bug.cgi?id=229001
<rdar://problem/81792379>

Reviewed by Devin Rousso.

Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.

* UserInterface/Views/ChangesDetailsSidebarPanel.js:
(WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):


Canonical link: https://commits.webkit.org/240593@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rcaliman-apple committed Aug 17, 2021
1 parent 553b956 commit 5fb216c9725e790e29ab36a469975d742de66483
@@ -1,3 +1,18 @@
2021-08-17 Razvan Caliman <rcaliman@apple.com>

Web Inspector: Do not show contextual documentation popup in the Changes panel
https://bugs.webkit.org/show_bug.cgi?id=229001
<rdar://problem/81792379>

Reviewed by Devin Rousso.

Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.

* UserInterface/Views/ChangesDetailsSidebarPanel.js:
(WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):

2021-08-12 Patrick Angle <pangle@apple.com>

Web Inspector: Adding execution contexts after page load doesn't show a hidden execution selector
@@ -143,7 +143,7 @@ WI.ChangesDetailsSidebarPanel = class ChangesDetailsSidebarPanel extends WI.DOMD
propertyLineElement.classList.add("css-property-line", className);

const delegate = null;
let stylePropertyView = new WI.SpreadsheetStyleProperty(delegate, cssProperty, {readOnly: true});
let stylePropertyView = new WI.SpreadsheetStyleProperty(delegate, cssProperty, {readOnly: true, hideDocumentation: true});
propertyLineElement.append(WI.indentString(), stylePropertyView.element, "\n");
}

@@ -34,6 +34,7 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
this._delegate = delegate || null;
this._property = property;
this._readOnly = options.readOnly || false;
this._hideDocumentation = !!options.hideDocumentation;
this._element = document.createElement("div");

if (options.selectable)
@@ -527,6 +528,9 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object

_addContextualDocumentationButton()
{
if (this._hideDocumentation)
return;

if (this._contextualDocumentationButton) {
this._contextualDocumentationButton.remove();
this._contextualDocumentationButton = null;

0 comments on commit 5fb216c

Please sign in to comment.