Skip to content
Permalink
Browse files
[ews] Improve failure summary string for AnalyzeCompileWebKitResults …
…step

https://bugs.webkit.org/show_bug.cgi?id=216566

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.


Canonical link: https://commits.webkit.org/229436@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aj062 committed Sep 16, 2020
1 parent 2313eda commit 5fd2898c71ede3faf4bf788b2f24e5fc62c37f9c
Showing with 12 additions and 2 deletions.
  1. +2 −2 Tools/BuildSlaveSupport/ews-build/steps.py
  2. +10 −0 Tools/ChangeLog
@@ -1438,20 +1438,20 @@ def analyzeResults(self):
compile_without_patch_result = self.getStepResult(compile_without_patch_step)

if compile_without_patch_result == FAILURE:
self.finished(FAILURE)
message = 'Unable to build WebKit without patch, retrying build'
self.descriptionDone = message
self.send_email_for_preexisting_build_failure()
self.finished(FAILURE)
self.build.buildFinished([message], RETRY)
return defer.succeed(None)

self.finished(FAILURE)
self.build.results = FAILURE
patch_id = self.getProperty('patch_id', '')
message = 'Patch {} does not build'.format(patch_id)
self.send_email_for_new_build_failure()

self.descriptionDone = message
self.finished(FAILURE)
self.setProperty('build_finish_summary', message)
if self.getProperty('buildername', '').lower() == 'commit-queue':
self.setProperty('bugzilla_comment_text', message)
@@ -1,3 +1,13 @@
2020-09-16 Aakash Jain <aakash_jain@apple.com>

[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
https://bugs.webkit.org/show_bug.cgi?id=216566

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.

2020-09-16 Philippe Normand <pnormand@igalia.com>

[Flatpak] webkit-bwrap drive-by cleanups

0 comments on commit 5fd2898

Please sign in to comment.