Skip to content
Permalink
Browse files
REGRESSION (r232301) - Unable to enter video fullscreen
https://bugs.webkit.org/show_bug.cgi?id=186357
<rdar://problem/40838449>

Reviewed by Jon Lee.

Only set up the standby fullscreen element if we are in element fullscreen.

* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::videoControlsManagerDidChange):

Canonical link: https://commits.webkit.org/201729@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
jernoble committed Jun 6, 2018
1 parent 329bf9e commit 643c6d6df337015a00c3db4a7760373e27c90d00
Showing with 19 additions and 1 deletion.
  1. +13 −0 Source/WebKit/ChangeLog
  2. +6 −1 Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
@@ -1,3 +1,16 @@
2018-06-06 Jer Noble <jer.noble@apple.com>

REGRESSION (r232301) - Unable to enter video fullscreen
https://bugs.webkit.org/show_bug.cgi?id=186357
<rdar://problem/40838449>

Reviewed by Jon Lee.

Only set up the standby fullscreen element if we are in element fullscreen.

* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::videoControlsManagerDidChange):

2018-06-06 Jeremy Jones <jeremyj@apple.com>

attenuationFactor should be in range [0,1]
@@ -89,7 +89,12 @@ void WebFullScreenManager::videoControlsManagerDidChange()
{
#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
auto* currentPlaybackControlsElement = m_page->playbackSessionManager().currentPlaybackControlsElement();
setPIPStandbyElement(is<HTMLVideoElement>(currentPlaybackControlsElement) ? downcast<HTMLVideoElement>(currentPlaybackControlsElement) : nullptr);
if (!m_element || !is<HTMLVideoElement>(currentPlaybackControlsElement)) {
setPIPStandbyElement(nullptr);
return;
}

setPIPStandbyElement(downcast<HTMLVideoElement>(currentPlaybackControlsElement));
#endif
}

0 comments on commit 643c6d6

Please sign in to comment.