Skip to content
Permalink
Browse files
2011-04-13 Dirk Pranke <dpranke@chromium.org>
        Unreviewed, build fix.
        https://bugs.webkit.org/show_bug.cgi?id=52763

        r83799 broke test-webkitpy because it assumed we always have
        access to a real filesystem (we don't during the unit tests).
        Stubbing out the copy for now but we might need a better
        solution at some point.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

Canonical link: https://commits.webkit.org/73563@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dpranke committed Apr 14, 2011
1 parent 93613da commit 64c3238b51389242d758be7624c13cd6a29a182e
Showing 2 changed files with 16 additions and 1 deletion.
@@ -1,3 +1,15 @@
2011-04-13 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=52763

r83799 broke test-webkitpy because it assumed we always have
access to a real filesystem (we don't during the unit tests).
Stubbing out the copy for now but we might need a better
solution at some point.

* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

2011-04-13 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.
@@ -1194,7 +1194,10 @@ def _write_results_html_file(self, result_summary):
# FIXME: Have this replace results.html and have a checkbox for whether to show expected failures or not.
def _write_unexpected_results_html_file(self, unexpected_results):
base_dir = self._port.path_from_webkit_base('Tools', 'Scripts', 'webkitpy', 'layout_tests', 'layout_package')
self._fs.copyfile(self._fs.join(base_dir, "json_results.html"), self._fs.join(self._results_directory, "json_results.html"))
results_file = self._fs.join(base_dir, 'json_results.html')
# FIXME: What should we do if this doesn't exist (e.g., in unit tests)?
if self._fs.exists(results_file):
self._fs.copyfile(results_file, self._fs.join(self._results_directory, "json_results.html"))

def _show_results_html_file(self):
"""Shows the results.html page."""

0 comments on commit 64c3238

Please sign in to comment.