Skip to content
Permalink
Browse files
Cannot link WebKitTestRunner in non-unified builds
https://bugs.webkit.org/show_bug.cgi?id=240755

Reviewed by Adrian Perez de Castro.

In GTK non-unified build, WebKit shared library didn't export all
WEBCORE_EXPORT marked WebCore symbols because WebCore was a static
library.

WebCore should be an SHARED or OBJECT library to work WEBCORE_EXPORT
macro as expected.

* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/page/gtk/DragControllerGtk.cpp:
* Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/251011@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fujii committed May 26, 2022
1 parent 375bfed commit 663022c06df80d67bec019379f82a1b9764e66d2
Showing 5 changed files with 4 additions and 2 deletions.
@@ -6,8 +6,6 @@ include(platform/ImageDecoders.cmake)
include(platform/Soup.cmake)
include(platform/TextureMapper.cmake)

set(WebCore_OUTPUT_NAME WebCoreGTK)

list(APPEND WebCore_UNIFIED_SOURCE_LIST_FILES
"SourcesGTK.txt"

@@ -32,6 +32,7 @@
#include "Editor.h"
#include "Element.h"
#include "Frame.h"
#include "FrameDestructionObserverInlines.h"
#include "Pasteboard.h"
#include "markup.h"

@@ -33,6 +33,7 @@
#include "WebProcess.h"
#include <WebCore/DocumentLoader.h>
#include <WebCore/Frame.h>
#include <WebCore/FrameDestructionObserverInlines.h>
#include <WebCore/FrameLoader.h>
#include <WebCore/GraphicsContextCairo.h>
#include <WebCore/IntRect.h>
@@ -247,6 +247,7 @@ set(CMAKE_C_VISIBILITY_PRESET hidden)
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(bmalloc_LIBRARY_TYPE OBJECT)
set(WTF_LIBRARY_TYPE OBJECT)
set(WebCore_LIBRARY_TYPE OBJECT)

# These are shared variables, but we special case their definition so that we can use the
# CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.
@@ -178,6 +178,7 @@ set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)
set(bmalloc_LIBRARY_TYPE OBJECT)
set(WTF_LIBRARY_TYPE OBJECT)
set(JavaScriptCore_LIBRARY_TYPE OBJECT)
set(WebCore_LIBRARY_TYPE OBJECT)

# These are shared variables, but we special case their definition so that we can use the
# CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.

0 comments on commit 663022c

Please sign in to comment.