Skip to content
Permalink
Browse files
[Win] AX: Implement support for ARIA 1.1 'switch' role
https://bugs.webkit.org/show_bug.cgi?id=142016
<rdar://problem/19953264>

Reviewed by Chris Fleizach.

The changes in Bug 141986 did not update the proper Windows routines to
support the new ARIA 1.1 role. This turned out to be trivial.

* AccessibleBase.cpp:
(MSAARole): Provide MSAA role for 'switch'. Also correct 'ToggleButtonRole',
which was improperly reporting as 'push button'.


Canonical link: https://commits.webkit.org/160373@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
brentfulgham committed Mar 5, 2015
1 parent 33e01a5 commit 669c8ddbd4b30cb23203573ea3b4c33914005ad9
Showing 2 changed files with 17 additions and 2 deletions.
@@ -848,6 +848,8 @@ static long MSAARole(AccessibilityRole role)
case WebCore::RadioButtonRole:
return ROLE_SYSTEM_RADIOBUTTON;
case WebCore::CheckBoxRole:
case WebCore::ToggleButtonRole:
case WebCore::SwitchRole:
return ROLE_SYSTEM_CHECKBUTTON;
case WebCore::SliderRole:
return ROLE_SYSTEM_SLIDER;
@@ -915,8 +917,6 @@ static long MSAARole(AccessibilityRole role)
return ROLE_SYSTEM_SPINBUTTON;
case WebCore::SpinButtonPartRole:
return ROLE_SYSTEM_PUSHBUTTON;
case WebCore::ToggleButtonRole:
return ROLE_SYSTEM_PUSHBUTTON;
case WebCore::ToolbarRole:
return ROLE_SYSTEM_TOOLBAR;
case WebCore::UserInterfaceTooltipRole:
@@ -1,3 +1,18 @@
2015-03-04 Brent Fulgham <bfulgham@apple.com>

[Win] AX: Implement support for ARIA 1.1 'switch' role
https://bugs.webkit.org/show_bug.cgi?id=142016
<rdar://problem/19953264>

Reviewed by Chris Fleizach.

The changes in Bug 141986 did not update the proper Windows routines to
support the new ARIA 1.1 role. This turned out to be trivial.

* AccessibleBase.cpp:
(MSAARole): Provide MSAA role for 'switch'. Also correct 'ToggleButtonRole',
which was improperly reporting as 'push button'.

2015-03-04 Yusuke Suzuki <utatane.tea@gmail.com>

Hide Promise with runtime flags under Cocoa JSContext API

0 comments on commit 669c8dd

Please sign in to comment.