Skip to content
Permalink
Browse files
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
        Reviewed by Joseph Pecoraro.

        Web Inspector: mimic FireBug's array detection.
        https://bugs.webkit.org/show_bug.cgi?id=30974

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):


Canonical link: https://commits.webkit.org/56078@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
pavelfeldman committed Aug 12, 2010
1 parent a11a064 commit 66ae49806941495fd8e457e404059a8934c00b5c
Showing 2 changed files with 15 additions and 2 deletions.
@@ -1,3 +1,13 @@
2010-08-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: mimic FireBug's array detection.
https://bugs.webkit.org/show_bug.cgi?id=30974

* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):

2010-08-12 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.
@@ -519,12 +519,15 @@ InjectedScript._type = function(obj)
return "date";
if (obj instanceof inspectedWindow.RegExp)
return "regexp";
// FireBug's array detection.
if (isFinite(obj.length) && typeof obj.splice === "function")
return "array";
if (isFinite(obj.length) && typeof obj.callee === "function") // arguments.
return "array";
if (obj instanceof inspectedWindow.NodeList)
return "array";
if (obj instanceof inspectedWindow.HTMLCollection)
return "array";
if (typeof inspectedWindow.jQuery === "function" && obj instanceof inspectedWindow.jQuery)
return "array";
if (obj instanceof inspectedWindow.Error)
return "error";
return type;

0 comments on commit 66ae498

Please sign in to comment.