Followup to r224238: API::Attachment should generate a _WKAttachment …

…ObjC wrapper

https://bugs.webkit.org/show_bug.cgi?id=179080

Reviewed by Tim Horton.

Fixes a failing API test. The new Attachment object type added in r224238 was not actually being handled in
Object::newObject, so a plain WKObject Objective C wrapper was being created; fix this by allocating a new
_WKAttachment object for Type::Attachment.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):


Canonical link: https://commits.webkit.org/195209@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog

@@ -1,3 +1,17 @@
+2017-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Followup to r224238: API::Attachment should generate a _WKAttachment ObjC wrapper
+        https://bugs.webkit.org/show_bug.cgi?id=179080
+
+        Reviewed by Tim Horton.
+
+        Fixes a failing API test. The new Attachment object type added in r224238 was not actually being handled in
+        Object::newObject, so a plain WKObject Objective C wrapper was being created; fix this by allocating a new
+        _WKAttachment object for Type::Attachment.
+
+        * Shared/Cocoa/APIObject.mm:
+        (API::Object::newObject):
+
 2017-10-31  Tim Horton  <timothy_horton@apple.com>
 
         Fix up some content filtering feature flags

Source/WebKit/Shared/Cocoa/APIObject.mm

@@ -68,6 +68,7 @@
 #import "WKWebsiteDataRecordInternal.h"
 #import "WKWebsiteDataStoreInternal.h"
 #import "WKWindowFeaturesInternal.h"
+#import "_WKAttachmentInternal.h"
 #import "_WKAutomationSessionInternal.h"
 #import "_WKDownloadInternal.h"
 #import "_WKExperimentalFeatureInternal.h"
@@ -105,6 +106,10 @@
         wrapper = [WKNSArray alloc];
         break;
 
+    case Type::Attachment:
+        wrapper = [_WKAttachment alloc];
+        break;
+
     case Type::AuthenticationChallenge:
         wrapper = NSAllocateObject([WKNSURLAuthenticationChallenge self], size, nullptr);
         break;