This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AX: web process crash with isolated tree mode enabled
https://bugs.webkit.org/show_bug.cgi?id=234739 <rdar://problem/86983058> Reviewed by Chris Fleizach. It can happen that a new node being added is removed by AXIsolatedObject constructor when initializing ComputedLabel property, because AccessibilityObject::computedLabel() calls updateBackingStore() that can trigger a layout. We don't really need ComputedLabel property for isolated objects because AccessibilityObject::computedLabel() is only used by the inspector that uses AccessibilityObject directly. * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeAttributeData): Remove ComputedLabel property initialization. (WebCore::AXIsolatedObject::computedLabel): Assert if called. * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::createSubtree): Add an assert to ensure the wrapper is still valid after AXIsolatedObject::create(). * accessibility/isolatedtree/AXIsolatedTree.h: Canonical link: https://commits.webkit.org/245668@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing 5 changed files with 31 additions and 3 deletions.