REGRESSION (iOS 15): Safari loses Network access when establishing We…

…bRTC session

https://bugs.webkit.org/show_bug.cgi?id=233752
<rdar://problem/86196093>

Reviewed by Geoffrey Garen.

When we get an error from a UDP nw socket, we do not need to stop reading and close it.
We can just log the error and continue reading as the error might get fixed later on.

Not easily testable.

* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:



Canonical link: https://commits.webkit.org/245074@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog

@@ -1,3 +1,18 @@
+2021-12-10  Youenn Fablet  <youenn@apple.com>
+
+        REGRESSION (iOS 15): Safari loses Network access when establishing WebRTC session
+        https://bugs.webkit.org/show_bug.cgi?id=233752
+        <rdar://problem/86196093>
+
+        Reviewed by Geoffrey Garen.
+
+        When we get an error from a UDP nw socket, we do not need to stop reading and close it.
+        We can just log the error and continue reading as the error might get fixed later on.
+
+        Not easily testable.
+
+        * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+
 2021-12-10  Kimmo Kinnunen  <kkinnunen@apple.com>
 
         IOSurface memory attribution is hard to use in constructors

Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm

@@ -288,10 +288,8 @@ static inline void processUDPData(RetainPtr<nw_connection_t>&& nwConnection, Fun
         }
         if (isComplete && context && nw_content_context_get_is_final(context))
             return;
-        if (error) {
-            RELEASE_LOG_ERROR(WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));
-            return;
-        }
+
+        RELEASE_LOG_ERROR_IF(!!error, WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));
         processUDPData(WTFMove(nwConnection), WTFMove(processData));
     }).get());
 }