Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Summary on details has not right margin on RTL
Summary on `details` has not right margin on RTL
https://bugs.webkit.org/show_bug.cgi?id=250296
rdar://problem/104275835

Reviewed by Tim Nguyen.

This patch is to fix an issue in 'details' marker respecting 'margin' when in RTL
and have same margin as 'LTR'.

It is covered by existing tests, which will need to be rebaselined.

* Source/WebCore/css/html.css: Update 'summary::-webkit-details-marker'
* LayoutTests/platform/glib/fast/html/details-marker-style-expected.txt: Rebaselined
* LayoutTests/platform/glib/fast/html/details-marker-style-mixed-expected.txt: Rebaselined
* LayoutTests/platform/glib/fast/html/details-writing-mode-expected.txt: Rebaselined
* LayoutTests/platform/glib/fast/html/details-writing-mode-mixed-expected.txt: Rebaselined
* LayoutTests/platform/ios/fast/html/details-marker-style-expected.txt: Rebaselined
* LayoutTests/platform/ios/fast/html/details-marker-style-mixed-expected.txt: Rebaselined
* LayoutTests/platform/ios/fast/html/details-writing-mode-expected.txt: Rebaselined
* LayoutTests/platform/ios/fast/html/details-writing-mode-mixed-expected.txt: Rebaselined
* LayoutTests/platform/mac/fast/html/details-marker-style-expected.txt: Rebaselined
* LayoutTests/platform/mac/fast/html/details-marker-style-expected.png: Rebaselined
* LayoutTests/platform/mac/fast/html/details-marker-style-mixed-expected.txt: Rebaselined
* LayoutTests/platform/mac/fast/html/details-writing-mode-expected.txt: Rebaselined
* LayoutTests/platform/mac/fast/html/details-writing-mode-expected.png: Rebaselined
* LayoutTests/platform/mac/fast/html/details-writing-mode-mixed-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/260063@main
  • Loading branch information
Ahmad-S792 authored and Ahmad Saleem committed Feb 9, 2023
1 parent cdf4a0a commit 6a99d8b
Show file tree
Hide file tree
Showing 15 changed files with 866 additions and 866 deletions.
@@ -1,29 +1,29 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x456
RenderBlock {HTML} at (0,0) size 800x456
RenderBody {BODY} at (8,8) size 784x440
layer at (0,0) size 800x475
RenderBlock {HTML} at (0,0) size 800x476
RenderBody {BODY} at (8,8) size 784x460
RenderBlock {DIV} at (0,0) size 784x86
RenderBlock {DETAILS} at (0,0) size 784x86
RenderBlock {SUMMARY} at (0,0) size 784x86
RenderDetailsMarker {DIV} at (0,0) size 112x80 [border: (8px solid #00FF00) (16px solid #00FF00) (24px solid #00FF00) (32px solid #00FF00)]: right
RenderText {#text} at (121,59) size 95x26
text run at (121,59) width 95: "Summary"
RenderBlock {DIV} at (0,86) size 127x174
RenderBlock {DETAILS} at (0,0) size 127x174
RenderBlock {SUMMARY} at (0,0) size 127x174
RenderDetailsMarker {DIV} at (9,0) size 113x80 [border: (8px solid #00FF00) (16px solid #00FF00) (24px solid #00FF00) (32px solid #00FF00)]: down
RenderText {#text} at (100,79) size 26x95
text run at (100,79) width 94: "Summary"
RenderBlock {DIV} at (0,259) size 784x47
RenderBlock {DIV} at (0,86) size 118x184
RenderBlock {DETAILS} at (0,0) size 118x184
RenderBlock {SUMMARY} at (0,0) size 118x184
RenderDetailsMarker {DIV} at (0,0) size 112x80 [border: (8px solid #00FF00) (16px solid #00FF00) (24px solid #00FF00) (32px solid #00FF00)]: down
RenderText {#text} at (91,89) size 26x95
text run at (91,89) width 94: "Summary"
RenderBlock {DIV} at (0,269) size 784x47
RenderBlock {DETAILS} at (0,0) size 784x46
RenderBlock {SUMMARY} at (0,0) size 784x46
RenderDetailsMarker {DIV} at (0,0) size 64x40 [border: (8px solid #00FF00)]: right
RenderText {#text} at (73,19) size 95x26
text run at (73,19) width 95: "Summary"
RenderBlock {DIV} at (0,305) size 80x135
RenderBlock {DETAILS} at (0,0) size 80x134
RenderBlock {SUMMARY} at (0,0) size 80x134
RenderDetailsMarker {DIV} at (9,0) size 65x40 [border: (8px solid #00FF00)]: down
RenderText {#text} at (53,40) size 26x94
text run at (53,40) width 94: "Summary"
RenderBlock {DIV} at (0,315) size 70x145
RenderBlock {DETAILS} at (0,0) size 70x144
RenderBlock {SUMMARY} at (0,0) size 70x144
RenderDetailsMarker {DIV} at (0,0) size 64x40 [border: (8px solid #00FF00)]: down
RenderText {#text} at (43,49) size 26x95
text run at (43,49) width 94: "Summary"
@@ -1,29 +1,29 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x456
RenderBlock {HTML} at (0,0) size 800x456
RenderBody {BODY} at (8,8) size 784x440
layer at (0,0) size 800x475
RenderBlock {HTML} at (0,0) size 800x476
RenderBody {BODY} at (8,8) size 784x460
RenderBlock {DIV} at (0,0) size 784x86
RenderBlock {DETAILS} at (0,0) size 784x86
RenderBlock {SUMMARY} at (0,0) size 784x86
RenderDetailsMarker {DIV} at (0,0) size 112x80 [border: (8px solid #00FF00) (16px solid #00FF00) (24px solid #00FF00) (32px solid #00FF00)]: right
RenderText {#text} at (121,59) size 95x26
text run at (121,59) width 95: "Summary"
RenderBlock {DIV} at (0,86) size 121x174
RenderBlock {DETAILS} at (0,0) size 121x174
RenderBlock {SUMMARY} at (0,0) size 121x174
RenderDetailsMarker {DIV} at (9,0) size 113x80 [border: (8px solid #00FF00) (16px solid #00FF00) (24px solid #00FF00) (32px solid #00FF00)]: down
RenderText {#text} at (48,79) size 26x95
text run at (48,79) width 94: "Summary"
RenderBlock {DIV} at (0,259) size 784x47
RenderBlock {DIV} at (0,86) size 112x184
RenderBlock {DETAILS} at (0,0) size 112x184
RenderBlock {SUMMARY} at (0,0) size 112x184
RenderDetailsMarker {DIV} at (0,0) size 112x80 [border: (8px solid #00FF00) (16px solid #00FF00) (24px solid #00FF00) (32px solid #00FF00)]: down
RenderText {#text} at (43,89) size 26x95
text run at (43,89) width 94: "Summary"
RenderBlock {DIV} at (0,269) size 784x47
RenderBlock {DETAILS} at (0,0) size 784x46
RenderBlock {SUMMARY} at (0,0) size 784x46
RenderDetailsMarker {DIV} at (0,0) size 64x40 [border: (8px solid #00FF00)]: right
RenderText {#text} at (73,19) size 95x26
text run at (73,19) width 95: "Summary"
RenderBlock {DIV} at (0,305) size 74x135
RenderBlock {DETAILS} at (0,0) size 74x134
RenderBlock {SUMMARY} at (0,0) size 74x134
RenderDetailsMarker {DIV} at (9,0) size 65x40 [border: (8px solid #00FF00)]: down
RenderText {#text} at (24,40) size 26x94
text run at (24,40) width 94: "Summary"
RenderBlock {DIV} at (0,315) size 64x145
RenderBlock {DETAILS} at (0,0) size 64x144
RenderBlock {SUMMARY} at (0,0) size 64x144
RenderDetailsMarker {DIV} at (0,0) size 64x40 [border: (8px solid #00FF00)]: down
RenderText {#text} at (19,49) size 26x95
text run at (19,49) width 94: "Summary"

0 comments on commit 6a99d8b

Please sign in to comment.