This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid extracting the main video in element fullscreen when fullscreen…
… mode isn't active https://bugs.webkit.org/show_bug.cgi?id=240910 rdar://93906888 Reviewed by Eric Carlson. Add a check that we're actually still in element fullscreen before extracting the main video. Since `WebFullScreenManager` and its `m_element` both persist after exiting fullscreen mode, there's currently nothing preventing us from re-triggering video extraction when a video is paused once again outside of fullscreen mode. Covered by a new API test (more details in the bug). * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::handleEvent): (WebKit::WebFullScreenManager::mainVideoElementExtractionTimerFired): Deal with another corner case, wherein the main video element we previously detected may no longer be in the fullscreen element's subtree by the time that the extraction timer fires. To avoid this, always update the main video element again when the extraction timer is fired (as long as we're still in fullscreen mode), before proceeding with extraction. Canonical link: https://commits.webkit.org/250985@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing 1 changed file with 10 additions and 1 deletion.