Skip to content
Permalink
Browse files
Skip release assert during container query resolution
https://bugs.webkit.org/show_bug.cgi?id=239537

Patch by Rob Buis <rbuis@igalia.com> on 2022-04-21
Reviewed by Antti Koivisto.

Skip release assert during container query resolution
since resolveStyle will be a no-op as the container
query resolution was started in resolveStyle, so calling
resolveStyle the second time will bail right away.

* dom/Document.cpp:
(WebCore::Document::updateStyleIfNeeded):

Canonical link: https://commits.webkit.org/249843@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rwlbuis authored and webkit-commit-queue committed Apr 21, 2022
1 parent 002c921 commit 6c1e309c1452e85f1bfaac45bee67623580bb90c
Showing 2 changed files with 17 additions and 0 deletions.
@@ -1,3 +1,18 @@
2022-04-21 Rob Buis <rbuis@igalia.com>

Skip release assert during container query resolution
https://bugs.webkit.org/show_bug.cgi?id=239537

Reviewed by Antti Koivisto.

Skip release assert during container query resolution
since resolveStyle will be a no-op as the container
query resolution was started in resolveStyle, so calling
resolveStyle the second time will bail right away.

* dom/Document.cpp:
(WebCore::Document::updateStyleIfNeeded):

2022-04-20 Chris Dumez <cdumez@apple.com>

Unreviewed follow-up to r293123 to address review feedback from Sam & Darin
@@ -2191,6 +2191,8 @@ static bool isSafeToUpdateStyleOrLayout(const Document& document)

bool Document::updateStyleIfNeeded()
{
if (topDocument().isResolvingContainerQueries())
return false;
RefPtr<FrameView> frameView = view();
{
ScriptDisallowedScope::InMainThread scriptDisallowedScope;

0 comments on commit 6c1e309

Please sign in to comment.