[GTK] Layout Test http/tests/appcache/different-https-origin-resource…

…-main.html is failing

https://bugs.webkit.org/show_bug.cgi?id=145253

Reviewed by Michael Catanzaro.

Source/WebCore:

The problem is that when the load is cancelled while the
connection is still being established,
SoupMessage::notify::tls-errors is emitted and the handler calls
ResourceHandleClient::didFail() which can delete the ResourceHandle.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
for the scope of the callback because
ResourceHandleClient::didFail() could delete the object.

LayoutTests:

Update test expectation.

* platform/gtk/TestExpectations:

Canonical link: https://commits.webkit.org/171918@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog

@@ -1,3 +1,14 @@
+2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=145253
+
+        Reviewed by Michael Catanzaro.
+
+        Update test expectation.
+
+        * platform/gtk/TestExpectations:
+
 2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.

LayoutTests/platform/gtk/TestExpectations

@@ -1748,7 +1748,7 @@ webkit.org/b/123431 http/tests/css/link-css-disabled-value-with-slow-loading-she
 webkit.org/b/123431 http/tests/local/link-stylesheet-load-order-preload.html [ Failure ]
 webkit.org/b/123431 http/tests/local/link-stylesheet-load-order.html [ Failure Pass ]
 
-webkit.org/b/145253 http/tests/appcache/different-https-origin-resource-main.html  [ Failure Crash ]
+webkit.org/b/145253 http/tests/appcache/different-https-origin-resource-main.html  [ Failure ]
 
 #////////////////////////////////////////////////////////////////////////////////////////
 # Tests failing

Source/WebCore/ChangeLog

@@ -1,3 +1,20 @@
+2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=145253
+
+        Reviewed by Michael Catanzaro.
+
+        The problem is that when the load is cancelled while the
+        connection is still being established,
+        SoupMessage::notify::tls-errors is emitted and the handler calls
+        ResourceHandleClient::didFail() which can delete the ResourceHandle.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
+        for the scope of the callback because
+        ResourceHandleClient::didFail() could delete the object.
+
 2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.

Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -338,11 +338,11 @@ static bool handleUnignoredTLSErrors(ResourceHandle* handle, SoupMessage* messag
 
 static void tlsErrorsChangedCallback(SoupMessage* message, GParamSpec*, gpointer data)
 {
-    ResourceHandle* handle = static_cast<ResourceHandle*>(data);
+    RefPtr<ResourceHandle> handle = static_cast<ResourceHandle*>(data);
     if (!handle || handle->cancelledOrClientless())
         return;
 
-    if (handleUnignoredTLSErrors(handle, message))
+    if (handleUnignoredTLSErrors(handle.get(), message))
         handle->cancel();
 }