Skip to content
Permalink
Browse files
[GTK] [MSE] Turn MSE on by default
https://bugs.webkit.org/show_bug.cgi?id=167107

Reviewed by Carlos Alberto Lopez Perez.

Turn on the ENABLE_MEDIA_SOURCE build option. Fail the build if GStreamer 1.8 is not
installed and ENABLE_MEDIA_SOURCE has not been disabled.

* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:


Canonical link: https://commits.webkit.org/196249@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Michael Catanzaro committed Dec 1, 2017
1 parent ba46017 commit 6d95961efcab738ed06f34c90be769f75d38ca5a
Showing 5 changed files with 23 additions and 2 deletions.
@@ -1,3 +1,18 @@
2017-12-01 Michael Catanzaro <mcatanzaro@igalia.com>

[GTK] [MSE] Turn MSE on by default
https://bugs.webkit.org/show_bug.cgi?id=167107

Reviewed by Carlos Alberto Lopez Perez.

Turn on the ENABLE_MEDIA_SOURCE build option. Fail the build if GStreamer 1.8 is not
installed and ENABLE_MEDIA_SOURCE has not been disabled.

* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

2017-11-30 Stephan Szabo <stephan.szabo@sony.com>

Make LegacyCustomProtocolManager optional for network process
@@ -32,6 +32,12 @@ if (ENABLE_VIDEO OR ENABLE_WEB_AUDIO)
endif ()
endif ()

if (ENABLE_MEDIA_SOURCE)
if (PC_GSTREAMER_VERSION VERSION_LESS "1.8")
message(FATAL_ERROR "GStreamer 1.8 is needed for ENABLE_MEDIA_SOURCE.")
endif ()
endif ()

if (USE_GSTREAMER_GL)
if (PC_GSTREAMER_VERSION VERSION_LESS "1.10")
set(USE_GSTREAMER_GL OFF)
@@ -1,5 +1,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC ON)

WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE PRIVATE ON)

WEBKIT_OPTION_DEFINE(USE_GSTREAMER_GL "Whether to enable support for GStreamer GL" PRIVATE ON)
WEBKIT_OPTION_DEFINE(USE_GSTREAMER_MPEGTS "Whether to enable support for MPEG-TS" PRIVATE OFF)
@@ -142,7 +142,6 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_STREAM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})

@@ -25,7 +25,6 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC PUBLIC OFF)
# Changing these options is completely unsupported.
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOTIFICATIONS PRIVATE OFF)

0 comments on commit 6d95961

Please sign in to comment.