Skip to content
Permalink
Browse files
[webkit-patch] Format patch without version signature
https://bugs.webkit.org/show_bug.cgi?id=240516

Reviewed by Jonathan Bedard.

By default 'git-format-patch' adds a signature at the bottom of a diff
patch with Git version number, which the DiffParser wrongly interprets as
a patch chunk.

* Tools/Scripts/webkitpy/common/checkout/scm/git.py: Use knob
  '--no-signature' to emit patch without signature.

Canonical link: https://commits.webkit.org/251476@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dpino committed Jun 11, 2022
1 parent b4c270a commit 6e0d5652c9e470134896fd6fca9896e96734097c
Showing 1 changed file with 1 addition and 1 deletion.
@@ -361,7 +361,7 @@ def create_patch(self, git_commit=None, changed_files=None, git_index=False, com
if not commit_message or merge_base == head:
command = [self.executable_name, 'diff', '--binary', '--no-color', '--no-ext-diff', '--full-index', '--no-renames']
else:
command = [self.executable_name, 'format-patch', '--stdout', '--binary']
command = [self.executable_name, 'format-patch', '--no-signature', '--stdout', '--binary']

# Put code changes at the top of the patch and layout tests
# at the bottom, this makes for easier reviewing.

0 comments on commit 6e0d565

Please sign in to comment.