Skip to content
Permalink
Browse files
REGRESSION (r199635) Web Inspector: Percentages in Heap Allocations v…
…iew are too large

https://bugs.webkit.org/show_bug.cgi?id=156729
<rdar://problem/25796002>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-04-19
Reviewed by Timothy Hatcher.

* UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
Fix callsite that failed to be updated once percentageString
required 0..1 input instead of 0..100.

Canonical link: https://commits.webkit.org/174856@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Apr 19, 2016
1 parent 51a37d7 commit 6e8a32c5ece31bee5910743944ce297cf43b98fa
Showing with 15 additions and 2 deletions.
  1. +13 −0 Source/WebInspectorUI/ChangeLog
  2. +2 −2 Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js
@@ -1,3 +1,16 @@
2016-04-19 Joseph Pecoraro <pecoraro@apple.com>

REGRESSION (r199635) Web Inspector: Percentages in Heap Allocations view are too large
https://bugs.webkit.org/show_bug.cgi?id=156729
<rdar://problem/25796002>

Reviewed by Timothy Hatcher.

* UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
Fix callsite that failed to be updated once percentageString
required 0..1 input instead of 0..100.

2016-04-18 Timothy Hatcher <timothy@apple.com>

Web Inspector: NavigationSidebarPanel does a lot of style recalc and layout on busy sites
@@ -111,10 +111,10 @@ WebInspector.HeapSnapshotInstanceDataGridNode = class HeapSnapshotInstanceDataGr
let sizeElement = fragment.appendChild(document.createElement("span"));
sizeElement.classList.add("size");
sizeElement.textContent = Number.bytesToString(size);
let percent = (size / this._tree._heapSnapshot.totalSize) * 100;
let fraction = size / this._tree._heapSnapshot.totalSize;
let percentElement = fragment.appendChild(document.createElement("span"));
percentElement.classList.add("percentage");
percentElement.textContent = Number.percentageString(percent);
percentElement.textContent = Number.percentageString(fraction);
return fragment;
}

0 comments on commit 6e8a32c

Please sign in to comment.