Web Inspector: Asserts seen opening and closing Remote Web Inspector …

…windows

https://bugs.webkit.org/show_bug.cgi?id=167316
<rdar://problem/28891161>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-23
Reviewed by Alexey Proskuryakov.

* UIProcess/RemoteWebInspectorProxy.cpp:
(WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):
Assume read access, like the local web inspector, to Web Inspector resources.

* WebProcess/WebPage/RemoteWebInspectorUI.cpp:
(WebKit::RemoteWebInspectorUI::closeWindow):
Clear ourselves as the inspector frontend client when closing.

Canonical link: https://commits.webkit.org/184366@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog

@@ -1,3 +1,19 @@
+2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Asserts seen opening and closing Remote Web Inspector windows
+        https://bugs.webkit.org/show_bug.cgi?id=167316
+        <rdar://problem/28891161>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * UIProcess/RemoteWebInspectorProxy.cpp:
+        (WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):
+        Assume read access, like the local web inspector, to Web Inspector resources.
+
+        * WebProcess/WebPage/RemoteWebInspectorUI.cpp:
+        (WebKit::RemoteWebInspectorUI::closeWindow):
+        Clear ourselves as the inspector frontend client when closing.
+
 2017-01-20  Anders Carlsson  <andersca@apple.com>
 
         When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)

Source/WebKit2/UIProcess/RemoteWebInspectorProxy.cpp

@@ -129,6 +129,7 @@ void RemoteWebInspectorProxy::createFrontendPageAndWindow()
     trackInspectorPage(m_inspectorPage);
 
     m_inspectorPage->process().addMessageReceiver(Messages::RemoteWebInspectorProxy::messageReceiverName(), m_inspectorPage->pageID(), *this);
+    m_inspectorPage->process().assumeReadAccessToBaseURL(WebInspectorProxy::inspectorBaseURL());
 }
 
 void RemoteWebInspectorProxy::closeFrontendPageAndWindow()

Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp

@@ -119,6 +119,8 @@ void RemoteWebInspectorUI::bringToFront()
 
 void RemoteWebInspectorUI::closeWindow()
 {
+    m_page.corePage()->inspectorController().setInspectorFrontendClient(nullptr);
+
     WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::FrontendDidClose(), m_page.pageID());
 }