Skip to content
Permalink
Browse files
DataTransfer.cpp triggers -Wunused-but-set-variable
https://bugs.webkit.org/show_bug.cgi?id=178209

Reviewed by Wenson Hsieh.

Use the ASSERT_UNUSED to silence it.

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::filesFromPasteboardAndItemList const):

Canonical link: https://commits.webkit.org/194541@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
tpopela committed Oct 16, 2017
1 parent 0cbf28c commit 70fe9206278f2dfaf220e114b99bb380c29e2125
Showing with 14 additions and 1 deletion.
  1. +12 −0 Source/WebCore/ChangeLog
  2. +2 −1 Source/WebCore/dom/DataTransfer.cpp
@@ -1,3 +1,15 @@
2017-10-16 Tomas Popela <tpopela@redhat.com>

DataTransfer.cpp triggers -Wunused-but-set-variable
https://bugs.webkit.org/show_bug.cgi?id=178209

Reviewed by Wenson Hsieh.

Use the ASSERT_UNUSED to silence it.

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::filesFromPasteboardAndItemList const):

2017-10-15 Sam Weinig <sam@webkit.org>

[Settings] Split non-macro generated parts of Settings into SettingsBase base class
@@ -304,7 +304,8 @@ Vector<Ref<File>> DataTransfer::filesFromPasteboardAndItemList() const
itemListContainsItems = true;
}

ASSERT(!itemListContainsItems || !addedFilesFromPasteboard);
bool containsItemsAndFiles = itemListContainsItems && addedFilesFromPasteboard;
ASSERT_UNUSED(containsItemsAndFiles, !containsItemsAndFiles);
return files;
}

0 comments on commit 70fe920

Please sign in to comment.