From 71043532ea1d93571b517bd9ef78f6c66dd097e6 Mon Sep 17 00:00:00 2001 From: Carlos Garcia Campos Date: Mon, 16 Oct 2017 11:00:10 +0000 Subject: [PATCH] Merge r222204 - WebDriver: wrong key name for capabilities in new session response https://bugs.webkit.org/show_bug.cgi?id=177074 Reviewed by Brian Burg. We are using "value", it should be "capabilities". https://w3c.github.io/webdriver/webdriver-spec.html#new-session * WebDriverService.cpp: (WebDriver::WebDriverService::newSession): --- Source/WebDriver/ChangeLog | 13 +++++++++++++ Source/WebDriver/WebDriverService.cpp | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog index 792020173c82..b445ae15e362 100644 --- a/Source/WebDriver/ChangeLog +++ b/Source/WebDriver/ChangeLog @@ -1,3 +1,16 @@ +2017-09-18 Carlos Garcia Campos + + WebDriver: wrong key name for capabilities in new session response + https://bugs.webkit.org/show_bug.cgi?id=177074 + + Reviewed by Brian Burg. + + We are using "value", it should be "capabilities". + https://w3c.github.io/webdriver/webdriver-spec.html#new-session + + * WebDriverService.cpp: + (WebDriver::WebDriverService::newSession): + 2017-09-18 Carlos Garcia Campos WebDriver: HTTP responses should include Cache-Control header with no-cache value diff --git a/Source/WebDriver/WebDriverService.cpp b/Source/WebDriver/WebDriverService.cpp index 90a4df9bebcb..7b97e3b9bd84 100644 --- a/Source/WebDriver/WebDriverService.cpp +++ b/Source/WebDriver/WebDriverService.cpp @@ -625,7 +625,7 @@ void WebDriverService::newSession(RefPtr&& parameters, Function break; } } - resultObject->setObject(ASCIILiteral("value"), WTFMove(capabilitiesObject)); + resultObject->setObject(ASCIILiteral("capabilities"), WTFMove(capabilitiesObject)); completionHandler(CommandResult::success(WTFMove(resultObject))); }); });