[WPE] position:sticky content is not correctly offset on async scroll…

…ed overflow layers with an RTL vertical scrollbar

https://bugs.webkit.org/show_bug.cgi?id=226327

Reviewed by Darin Adler.

Source/WebCore:

Make sure to respect the origin of sticky positioning nodes'
constraining rect.

No new tests, covered by existing tests.

* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
* page/scrolling/nicosia/ScrollingTreeStickyNode.cpp:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):

LayoutTests:

Some sticky-positioning RTL related tests now pass.

* platform/wpe/TestExpectations:


Canonical link: https://commits.webkit.org/238453@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog

@@ -1,3 +1,14 @@
+2021-06-03  Chris Lord  <clord@igalia.com>
+
+        [WPE] position:sticky content is not correctly offset on async scrolled overflow layers with an RTL vertical scrollbar
+        https://bugs.webkit.org/show_bug.cgi?id=226327
+
+        Reviewed by Darin Adler.
+
+        Some sticky-positioning RTL related tests now pass.
+
+        * platform/wpe/TestExpectations:
+
 2021-06-03  Simon Fraser  <simon.fraser@apple.com>
 
         REGRESSION (Safari 14): Menu items jump around on codelearn.cat

LayoutTests/platform/wpe/TestExpectations

@@ -716,8 +716,6 @@ webkit.org/b/224596 css3/filters/clipping-overflow-scroll-with-pixel-moving-effe
 webkit.org/b/224596 css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html [ ImageOnlyFailure ]
 webkit.org/b/224596 fast/scrolling/rtl-scrollbars-overflow-dir-rtl.html [ ImageOnlyFailure ]
 webkit.org/b/224596 fast/scrolling/rtl-scrollbars-overflow-padding.html [ ImageOnlyFailure ]
-webkit.org/b/224596 fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html [ ImageOnlyFailure ]
-webkit.org/b/224596 fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html [ ImageOnlyFailure ]
 webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html [ ImageOnlyFailure ]
 webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html [ ImageOnlyFailure ]
 webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-position/hypothetical-box-scroll-parent.html [ ImageOnlyFailure ]

Source/WebCore/ChangeLog

@@ -1,3 +1,20 @@
+2021-06-03  Chris Lord  <clord@igalia.com>
+
+        [WPE] position:sticky content is not correctly offset on async scrolled overflow layers with an RTL vertical scrollbar
+        https://bugs.webkit.org/show_bug.cgi?id=226327
+
+        Reviewed by Darin Adler.
+
+        Make sure to respect the origin of sticky positioning nodes'
+        constraining rect.
+
+        No new tests, covered by existing tests.
+
+        * page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
+        (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
+        * page/scrolling/nicosia/ScrollingTreeStickyNode.cpp:
+        (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
+
 2021-06-03  Simon Fraser  <simon.fraser@apple.com>
 
         REGRESSION (Safari 14): Menu items jump around on codelearn.cat

Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm

@@ -76,7 +76,8 @@
             constrainingRect = frameScrollingNode.layoutViewport();
         } else {
             auto& overflowScrollingNode = downcast<ScrollingTreeOverflowScrollingNode>(scrollingNode);
-            constrainingRect = FloatRect(overflowScrollingNode.currentScrollOffset(), m_constraints.constrainingRectAtLastLayout().size());
+            constrainingRect = m_constraints.constrainingRectAtLastLayout();
+            constrainingRect.move(overflowScrollingNode.scrollDeltaSinceLastCommit());
         }
         return m_constraints.layerPositionForConstrainingRect(constrainingRect);
     };

Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.cpp

@@ -118,7 +118,8 @@ FloatPoint ScrollingTreeStickyNode::computeLayerPosition() const
             constrainingRect = frameScrollingNode.layoutViewport();
         } else {
             auto& overflowScrollingNode = downcast<ScrollingTreeOverflowScrollingNode>(scrollingNode);
-            constrainingRect = FloatRect(overflowScrollingNode.currentScrollOffset(), m_constraints.constrainingRectAtLastLayout().size());
+            constrainingRect = m_constraints.constrainingRectAtLastLayout();
+            constrainingRect.move(overflowScrollingNode.scrollDeltaSinceLastCommit());
         }
         return m_constraints.layerPositionForConstrainingRect(constrainingRect);
     };