Skip to content
Permalink
Browse files
[Gtk] Support private browsing mode in plugins.
https://bugs.webkit.org/show_bug.cgi?id=35500

Integrate the PluginViewQt.cpp changes from
r55358 into Gtk+ and unskip the test.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
* platform/gtk/Skipped:

Canonical link: https://commits.webkit.org/46706@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
zecke committed Mar 2, 2010
1 parent 3045b44 commit 719373f26bdd2a311ee98e76645175754708906a
Showing 4 changed files with 31 additions and 2 deletions.
@@ -1,3 +1,14 @@
2010-02-28 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Gustavo Noronha.

[Gtk] Support private browsing mode in plugins.
https://bugs.webkit.org/show_bug.cgi?id=35500

Unskip test after taking code from PluginViewQt.cpp

* platform/gtk/Skipped:

2010-02-27 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.
@@ -3590,8 +3590,6 @@ plugins/private-browsing-mode.html

# https://bugs.webkit.org/show_bug.cgi?id=30561
plugins/private-browsing-mode.html
# https://bugs.webkit.org/show_bug.cgi?id=33180
plugins/private-browsing-mode-2.html

# Tests generating new results
plugins/embed-attributes-style.html
@@ -1,3 +1,15 @@
2010-02-28 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Gustavo Noronha.

[Gtk] Support private browsing mode in plugins.
https://bugs.webkit.org/show_bug.cgi?id=35500

Integrate the PluginViewQt.cpp changes from r55358 into Gtk+.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):

2010-03-02 Oliver Hunt <oliver@apple.com>

Reviewed by NOBODY (Build fix).
@@ -700,6 +700,14 @@ NPError PluginView::getValue(NPNVariable variable, void* value)
return NPERR_NO_ERROR;
}

case NPNVprivateModeBool: {
Page* page = m_parentFrame->page();
if (!page)
return NPERR_GENERIC_ERROR;
*((NPBool*)value) = !page->settings() || page->settings()->privateBrowsingEnabled();
return NPERR_NO_ERROR;
}

default:
return getValueStatic(variable, value);
}

0 comments on commit 719373f

Please sign in to comment.