Skip to content
Permalink
Browse files
[libpas] Enable libpas on ARM64 Darwin platforms (ARM64E is already e…
…nabled)

https://bugs.webkit.org/show_bug.cgi?id=234416

Reviewed by Filip Pizlo.

r287168 fixed libpas compare_and_swap on ARM64 so that we pass all libpas tests on ARM64 platforms.
Speedometer2 and JetStream2 are neutral, PLUM3 is 10.79% better, and RAMification is 2.83% better.

* bmalloc/BPlatform.h:


Canonical link: https://commits.webkit.org/245345@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Constellation committed Dec 17, 2021
1 parent ae0f5e8 commit 74a7664364d7fff640de0d880db7120adcfc55c5
Showing 2 changed files with 13 additions and 2 deletions.
@@ -1,3 +1,15 @@
2021-12-16 Yusuke Suzuki <ysuzuki@apple.com>

[libpas] Enable libpas on ARM64 Darwin platforms (ARM64E is already enabled)
https://bugs.webkit.org/show_bug.cgi?id=234416

Reviewed by Filip Pizlo.

r287168 fixed libpas compare_and_swap on ARM64 so that we pass all libpas tests on ARM64 platforms.
Speedometer2 and JetStream2 are neutral, PLUM3 is 10.79% better, and RAMification is 2.83% better.

* bmalloc/BPlatform.h:

2021-12-16 Yusuke Suzuki <ysuzuki@apple.com>

[libpas] ARM64 CAS emulation loop needs dmb ish
@@ -324,8 +324,7 @@

/* BENABLE(LIBPAS) is enabling libpas build. But this does not mean we use libpas for bmalloc replacement. */
#if !defined(BENABLE_LIBPAS)
/* Currently not enabling libpas on ARM64 (not ARM64E) on iOS family due to performance reason. */
#if BCPU(ADDRESS64) && (BOS(MAC) || (BPLATFORM(COCOA) && (BCPU(X86_64) || BCPU(ARM64E))) || (BOS(LINUX) && !BPLATFORM(GTK) && !BPLATFORM(WPE)))
#if BCPU(ADDRESS64) && (BOS(DARWIN) || (BOS(LINUX) && !BPLATFORM(GTK) && !BPLATFORM(WPE)))
#define BENABLE_LIBPAS 1
#else
#define BENABLE_LIBPAS 0

0 comments on commit 74a7664

Please sign in to comment.