Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GTK] Improve Ctrl+W and Ctrl+Q shortcuts in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=176619 Reviewed by Carlos Garcia Campos. There are two different problems here. First, Ctrl+W is closing the entire window. That made sense when I implemented the shortcut a couple years ago, but now MiniBrowser supports tabs and it should really close only one single tab. Fix that. Next, the keyboard shortcuts are not using webkit_web_view_try_close() and so are bypassing onbeforeunload handlers, which are respected when closing with the mouse. Fix that too. * MiniBrowser/gtk/BrowserWindow.c: (browserWindowTryCloseCurrentWebView): (browserWindowTryClose): (browser_window_init): Canonical link: https://commits.webkit.org/193182@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing with 44 additions and 18 deletions.