This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pa…
…k in gyp https://bugs.webkit.org/show_bug.cgi?id=111508 Patch by James Robinson <firstname.lastname@example.org> on 2013-03-06 Reviewed by Dirk Pranke. Some tests in webkit_unit_tests, for example WebPageSerializerTest.HTMLNodes, depend on localizable resources from a pak file. Since unit tests initialize for testing with the same webkit_support functions as layout tests they end up using DumpRenderTree.pak, but this dependency isn't listed explicitly in the gyp so if you manage to run webkit_unit_tests without building DumpRenderTree first these tests just crash. This adds a dependency from webkit_unit_tests to DumpRenderTree_resources so the pak is always built. It's a bit weird for a gyp file in Source/WebKit/chromium/ to reach into Tools/DumpRenderTree, but I can't think of anything better. * WebKitUnitTests.gyp: Canonical link: https://commits.webkit.org/129983@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing 2 changed files with 23 additions and 4 deletions.