Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…html fails with async delegates https://bugs.webkit.org/show_bug.cgi?id=183460 Reviewed by Alex Christensen. The test has 3 frames which all initially load "about:blank". Then using document.write(), it inserts HTML in each frame. Frame 1: body has an onload event handler, which calls JS is click an anchor link to navigate the frame. Frame 2: body has an onload event handler to do some logging Frame 3: body has an onload event handler and finishes the test (calls testRunner.notifyDone()) The issue is that with asynchronous policy delegates, the first frame may not have navigated yet by the time the third frame is loaded. Indeed, the onload event of the first frame merely clicks am anchor link which will trigger a navigation policy check and then later navigate. To make the test more robust, we now count the number of loads and call testRunner.notifyDone() when we've reached the expected number of loads. * http/tests/security/frame-loading-via-document-write-async-delegates-expected.txt: Added. * http/tests/security/frame-loading-via-document-write-async-delegates.html: Copied from LayoutTests/http/tests/security/frame-loading-via-document-write.html. * http/tests/security/frame-loading-via-document-write.html: * http/tests/security/resources/frame-loading-via-document-write.js: Canonical link: https://commits.webkit.org/199233@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing with 144 additions and 13 deletions.
- +25 −0 LayoutTests/ChangeLog
- +4 −0 LayoutTests/TestExpectations
- +21 −0 LayoutTests/http/tests/security/frame-loading-via-document-write-async-delegates-expected.txt
- +82 −0 LayoutTests/http/tests/security/frame-loading-via-document-write-async-delegates.html
- +0 −1 LayoutTests/http/tests/security/frame-loading-via-document-write-expected.txt
- +12 −4 LayoutTests/http/tests/security/frame-loading-via-document-write.html
- +0 −8 LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js