Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
[css shapes] Parse new ellipse shape syntax
https://bugs.webkit.org/show_bug.cgi?id=124620 Patch by Rob Buis <rob.buis@samsung.com> on 2013-12-02 Reviewed by Dirk Schulze. Source/WebCore: Implement parsing of the new ellipse shape syntax. This closely follows the patch for the new circle syntax (https://bugs.webkit.org/show_bug.cgi?id=124618), with some refactoring of functionality shared by both. Updated existing parsing tests to cover this. * css/BasicShapeFunctions.cpp: (WebCore::BasicShapeRadiusToCSSValue): (WebCore::valueForBasicShape): (WebCore::CSSValueToBasicShapeRadius): (WebCore::basicShapeForValue): * css/CSSBasicShapes.cpp: (WebCore::buildEllipseString): (WebCore::CSSBasicShapeEllipse::cssText): (WebCore::CSSBasicShapeEllipse::equals): (WebCore::buildDeprecatedEllipseString): (WebCore::CSSDeprecatedBasicShapeEllipse::cssText): (WebCore::CSSDeprecatedBasicShapeEllipse::equals): * css/CSSBasicShapes.h: (WebCore::CSSDeprecatedBasicShapeEllipse::create): (WebCore::CSSDeprecatedBasicShapeEllipse::centerX): (WebCore::CSSDeprecatedBasicShapeEllipse::centerY): (WebCore::CSSDeprecatedBasicShapeEllipse::radiusX): (WebCore::CSSDeprecatedBasicShapeEllipse::radiusY): (WebCore::CSSDeprecatedBasicShapeEllipse::setCenterX): (WebCore::CSSDeprecatedBasicShapeEllipse::setCenterY): (WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusX): (WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusY): (WebCore::CSSDeprecatedBasicShapeEllipse::CSSDeprecatedBasicShapeEllipse): * css/CSSParser.cpp: (WebCore::CSSParser::parseBasicShapeEllipse): (WebCore::CSSParser::parseDeprecatedBasicShapeEllipse): (WebCore::CSSParser::parseBasicShape): * css/CSSParser.h: * rendering/shapes/Shape.cpp: (WebCore::Shape::createShape): * rendering/style/BasicShapes.cpp: (WebCore::DeprecatedBasicShapeEllipse::path): (WebCore::DeprecatedBasicShapeEllipse::blend): (WebCore::BasicShapeEllipse::path): (WebCore::BasicShapeEllipse::blend): * rendering/style/BasicShapes.h: (WebCore::BasicShapeEllipse::centerX): (WebCore::BasicShapeEllipse::centerY): (WebCore::BasicShapeEllipse::radiusX): (WebCore::BasicShapeEllipse::radiusY): (WebCore::BasicShapeEllipse::setCenterX): (WebCore::BasicShapeEllipse::setCenterY): (WebCore::BasicShapeEllipse::setRadiusX): (WebCore::BasicShapeEllipse::setRadiusY): (WebCore::BasicShapeEllipse::BasicShapeEllipse): (WebCore::DeprecatedBasicShapeEllipse::create): (WebCore::DeprecatedBasicShapeEllipse::DeprecatedBasicShapeEllipse): LayoutTests: Test that the new ellipse syntax is properly parsed. * fast/shapes/parsing/parsing-shape-inside-expected.txt: * fast/shapes/parsing/parsing-shape-outside-expected.txt: * fast/shapes/parsing/parsing-test-utils.js: Canonical link: https://commits.webkit.org/143196@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
e9762b6
commit 769b7aada40d8ddb7b47d5c5a5a12482e0c3cdd1
Showing
13 changed files
with
512 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.