Skip to content
Permalink
Browse files
[GTK][WPE] Fix some build errors in service workers code
https://bugs.webkit.org/show_bug.cgi?id=182966

Reviewed by Žan Doberšek.

Source/WebCore:

No new tests: no change in behavior.

* workers/service/ServiceWorkerProvider.h: add missing forward declaration.

Source/WebKit:

* CMakeLists.txt: add missing files.
* StorageProcess/ServiceWorker/WebSWServerConnection.cpp: add missing includes.
* UIProcess/ServiceWorkerProcessProxy.cpp: use #include rather than #import in C++; add missing ifdef.
* UIProcess/ServiceWorkerProcessProxy.h: add missing ifdef.
* WebProcess/Storage/WebSWClientConnection.cpp: add missing includes.
* WebProcess/Storage/WebSWContextManagerConnection.cpp: add missing includes.
(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
  call the function that exists outside cocoa.


Canonical link: https://commits.webkit.org/198784@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Ms2ger committed Feb 22, 2018
1 parent ef4b791 commit 76dde9034adab500e1c69105c8da6b581f776606
@@ -1,3 +1,14 @@
2018-02-22 Ms2ger <Ms2ger@igalia.com>

[GTK][WPE] Fix some build errors in service workers code
https://bugs.webkit.org/show_bug.cgi?id=182966

Reviewed by Žan Doberšek.

No new tests: no change in behavior.

* workers/service/ServiceWorkerProvider.h: add missing forward declaration.

2018-02-21 Zalan Bujtas <zalan@apple.com>

[RenderTreeBuilder] Move RenderObject::insertedInto() mutation logic to RenderTreeBuilder
@@ -34,6 +34,7 @@ class SessionID;
namespace WebCore {

class SWClientConnection;
class SecurityOrigin;
class ServiceWorkerJob;

class WEBCORE_EXPORT ServiceWorkerProvider {
@@ -287,6 +287,7 @@ set(WebKit_SOURCES

StorageProcess/ServiceWorker/WebSWOriginStore.cpp
StorageProcess/ServiceWorker/WebSWServerConnection.cpp
StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp

UIProcess/BackgroundProcessResponsivenessTimer.cpp
UIProcess/ChildProcessProxy.cpp
@@ -300,6 +301,7 @@ set(WebKit_SOURCES
UIProcess/RemoteWebInspectorProxy.cpp
UIProcess/ResourceLoadStatisticsPersistentStorage.cpp
UIProcess/ResponsivenessTimer.cpp
UIProcess/ServiceWorkerProcessProxy.cpp
UIProcess/StatisticsRequest.cpp
UIProcess/TextCheckerCompletion.cpp
UIProcess/UIMessagePortChannelProvider.cpp
@@ -630,6 +632,7 @@ set(WebKit_MESSAGES_IN_FILES
StorageProcess/IndexedDB/WebIDBConnectionToClient.messages.in

StorageProcess/ServiceWorker/WebSWServerConnection.messages.in
StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in

UIProcess/DrawingAreaProxy.messages.in
UIProcess/RemoteWebInspectorProxy.messages.in
@@ -1,3 +1,19 @@
2018-02-22 Ms2ger <Ms2ger@igalia.com>

[GTK][WPE] Fix some build errors in service workers code
https://bugs.webkit.org/show_bug.cgi?id=182966

Reviewed by Žan Doberšek.

* CMakeLists.txt: add missing files.
* StorageProcess/ServiceWorker/WebSWServerConnection.cpp: add missing includes.
* UIProcess/ServiceWorkerProcessProxy.cpp: use #include rather than #import in C++; add missing ifdef.
* UIProcess/ServiceWorkerProcessProxy.h: add missing ifdef.
* WebProcess/Storage/WebSWClientConnection.cpp: add missing includes.
* WebProcess/Storage/WebSWContextManagerConnection.cpp: add missing includes.
(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
call the function that exists outside cocoa.

2018-02-21 Per Arne Vollan <pvollan@apple.com>

The WebContent process should not use NSScreen in the screenAvailableRect/screenRect implementations.
@@ -41,6 +41,7 @@
#include "WebSWServerConnectionMessages.h"
#include "WebSWServerToContextConnection.h"
#include "WebToStorageProcessConnection.h"
#include <WebCore/DocumentIdentifier.h>
#include <WebCore/ExceptionData.h>
#include <WebCore/NotImplemented.h>
#include <WebCore/SWServerRegistration.h>
@@ -49,6 +50,7 @@
#include <WebCore/ServiceWorkerClientIdentifier.h>
#include <WebCore/ServiceWorkerContextData.h>
#include <WebCore/ServiceWorkerJobData.h>
#include <WebCore/ServiceWorkerUpdateViaCache.h>
#include <wtf/MainThread.h>

using namespace PAL;
@@ -23,9 +23,11 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/

#import "config.h"
#include "config.h"
#include "ServiceWorkerProcessProxy.h"

#if ENABLE(SERVICE_WORKER)

#include "AuthenticationChallengeProxy.h"
#include "WebCredential.h"
#include "WebPageGroup.h"
@@ -100,3 +102,5 @@ void ServiceWorkerProcessProxy::didReceiveAuthenticationChallenge(uint64_t pageI
}

} // namespace WebKit

#endif // ENABLE(SERVICE_WORKER)
@@ -25,6 +25,8 @@

#pragma once

#if ENABLE(SERVICE_WORKER)

#include "WebProcessProxy.h"

namespace WebKit {
@@ -57,3 +59,5 @@ class ServiceWorkerProcessProxy final : public WebProcessProxy {
};

} // namespace WebKit

#endif // ENABLE(SERVICE_WORKER)
@@ -44,6 +44,7 @@
#include <WebCore/ServiceWorkerFetchResult.h>
#include <WebCore/ServiceWorkerJobData.h>
#include <WebCore/ServiceWorkerRegistrationData.h>
#include <WebCore/ServiceWorkerRegistrationKey.h>

using namespace PAL;
using namespace WebCore;
@@ -53,6 +53,8 @@
#include <WebCore/SerializedScriptValue.h>
#include <WebCore/ServiceWorkerClientData.h>
#include <WebCore/ServiceWorkerClientIdentifier.h>
#include <WebCore/ServiceWorkerClientQueryOptions.h>
#include <WebCore/ServiceWorkerJobDataIdentifier.h>
#include <WebCore/UserAgent.h>
#include <pal/SessionID.h>

@@ -107,7 +109,11 @@ WebSWContextManagerConnection::WebSWContextManagerConnection(Ref<IPC::Connection
: m_connectionToStorageProcess(WTFMove(connection))
, m_pageGroupID(pageGroupID)
, m_pageID(pageID)
#if PLATFORM(COCOA)
, m_userAgent(standardUserAgentWithApplicationName({ }))
#else
, m_userAgent(standardUserAgent())
#endif
{
updatePreferencesStore(store);
}

0 comments on commit 76dde90

Please sign in to comment.