Skip to content
Permalink
Browse files
Update transforms for table sections
https://bugs.webkit.org/show_bug.cgi?id=245016

Reviewed by Simon Fraser.

The computed anchor point for transforms is based on the resolved transform origin value. This transform origin value depends on the final geometry of the associated renderer.
This patch updates it by calling updateLayerTransform() when the table section geometry is set.
(Without this fix, the anchor point computed as if the box was zero sized -e.g. center behaves as top/left.)

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):

Canonical link: https://commits.webkit.org/254351@main
  • Loading branch information
alanbaradlay committed Sep 10, 2022
1 parent ddd1381 commit 77495cc12dd9e38ee023229cc2a6f1f946dd14b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
@@ -4139,9 +4139,6 @@ webkit.org/b/207262 imported/w3c/web-platform-tests/web-animations/timing-model/
webkit.org/b/210963 imported/w3c/web-platform-tests/css/css-animations/animation-important-002.html [ ImageOnlyFailure ]
webkit.org/b/235110 imported/w3c/web-platform-tests/css/css-animations/flip-running-animation-via-variable.html [ ImageOnlyFailure ]

webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tbody-contains-fixed-position.html [ ImageOnlyFailure ]
webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tfoot-contains-fixed-position.html [ ImageOnlyFailure ]
webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-thead-contains-fixed-position.html [ ImageOnlyFailure ]
webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-percent-height-child.html [ ImageOnlyFailure ]

webkit.org/b/235063 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
@@ -625,6 +625,8 @@ void RenderTableSection::layoutRows()

setLogicalHeight(m_rowPos[totalRows]);

updateLayerTransform();

computeOverflowFromCells(totalRows, nEffCols);
}

0 comments on commit 77495cc

Please sign in to comment.