Skip to content
Permalink
Browse files
2010-10-19 Evan Martin <evan@chromium.org>
        Reviewed by Tony Chang.

        sqlite: remove unused member variable
        https://bugs.webkit.org/show_bug.cgi?id=47957

        There's no need to save the error code into a member variable
        because nobody ever looks at it.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::open):
        * platform/sql/SQLiteDatabase.h:

Canonical link: https://commits.webkit.org/60670@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Evan Martin committed Oct 20, 2010
1 parent 813af0b commit 788807caa390fa7429e64e9321143c9fe547ff16
Showing 3 changed files with 15 additions and 3 deletions.
@@ -1,3 +1,17 @@
2010-10-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

sqlite: remove unused member variable
https://bugs.webkit.org/show_bug.cgi?id=47957

There's no need to save the error code into a member variable
because nobody ever looks at it.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
* platform/sql/SQLiteDatabase.h:

2010-10-19 Jia Pu <jpu@apple.com>

Reviewed by James Robinson.
@@ -65,8 +65,7 @@ bool SQLiteDatabase::open(const String& filename, bool forWebSQLDatabase)
{
close();

m_lastError = SQLiteFileSystem::openDatabase(filename, &m_db, forWebSQLDatabase);
if (m_lastError != SQLITE_OK) {
if (SQLiteFileSystem::openDatabase(filename, &m_db, forWebSQLDatabase) != SQLITE_OK) {
LOG_ERROR("SQLite database failed to load from %s\nCause - %s", filename.ascii().data(),
sqlite3_errmsg(m_db));
sqlite3_close(m_db);
@@ -139,7 +139,6 @@ class SQLiteDatabase : public Noncopyable {
int pageSize();

sqlite3* m_db;
int m_lastError;
int m_pageSize;

bool m_transactionInProgress;

0 comments on commit 788807c

Please sign in to comment.