Skip to content
Permalink
Browse files
[GTK] accessibility/gtk/entry-and-password.html is failing since r194847
https://bugs.webkit.org/show_bug.cgi?id=153062

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The changes in r194847 include using WebCore's rendering for the CapsLock indicator.
As a side effect, password inputs gained a TextControlInnerTextElement child from
the Shadow DOM. If we include that child in the accessibility tree, the child will
emit focus and text notifications that suggest the user is no longer in the control.
This can be especially problematic for screen reader users with key echo enabled
when typing in a password input. To fix this, prune TextControlInnerTextElement
children from the accessibility tree for ATK.

No new tests as existing coverage caught this regression. Also modified the
auto-fill-crash.html test whose expectations include the children count for
a text input.

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

The auto-fill-crash.html test has expectations which include the children
count for the text input. These expectations were incorrect for ATK where
accessible text inputs lack accessible text children.

* accessibility/auto-fill-crash.html: Modified to take platform into account.
* platform/gtk/TestExpectations: Unskipped entry-and-password.html.
* platform/gtk/accessibility/auto-fill-crash-expected.txt: Added.


Canonical link: https://commits.webkit.org/174850@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
joanmarie committed Apr 19, 2016
1 parent 6ae3e00 commit 78b631632d3ef118354a014c38a9fab86171e8cf
@@ -1,3 +1,18 @@
2016-04-19 Joanmarie Diggs <jdiggs@igalia.com>

[GTK] accessibility/gtk/entry-and-password.html is failing since r194847
https://bugs.webkit.org/show_bug.cgi?id=153062

Reviewed by Carlos Garcia Campos.

The auto-fill-crash.html test has expectations which include the children
count for the text input. These expectations were incorrect for ATK where
accessible text inputs lack accessible text children.

* accessibility/auto-fill-crash.html: Modified to take platform into account.
* platform/gtk/TestExpectations: Unskipped entry-and-password.html.
* platform/gtk/accessibility/auto-fill-crash-expected.txt: Added.

2016-04-19 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed GTK+ gardening. Rebaseline tests after r190840.
@@ -17,12 +17,14 @@

if (window.accessibilityController) {
var axTextField = accessibilityController.accessibleElementById("textfield");
var childrenCountExpected = accessibilityController.platformName == "atk" ? "2" : "3";
window.internals.setShowAutoFillButton(document.getElementById("textfield"), "AutoFillButtonTypeContacts");
shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", "3");
shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", childrenCountExpected);

// Don't crash!
childrenCountExpected = accessibilityController.platformName == "atk" ? "0" : "1";
window.internals.setShowAutoFillButton(document.getElementById("textfield"), "AutoFillButtonTypeNone");
shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", "1");
shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", childrenCountExpected);
}

</script>
@@ -2522,8 +2522,6 @@ webkit.org/b/152908 pageoverlay/overlay-large-document.html [ Failure ]
webkit.org/b/152908 pageoverlay/overlay-small-frame-mouse-events.html [ Failure ]
webkit.org/b/152908 pageoverlay/overlay-small-frame-paints.html [ Failure ]

webkit.org/b/153062 accessibility/gtk/entry-and-password.html [ Failure ]

webkit.org/b/153602 fast/table/003.html [ Failure ]
webkit.org/b/153602 fast/text/emoji.html [ Failure ]
webkit.org/b/153602 tables/mozilla_expected_failures/bugs/bug89315.html [ Failure ]
@@ -0,0 +1,12 @@

This tests that when an auto fill element is removed we won't crash accessing an old value.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS accessibilityController.accessibleElementById('textfield').childrenCount is 2
PASS accessibilityController.accessibleElementById('textfield').childrenCount is 0
PASS successfullyParsed is true

TEST COMPLETE

@@ -1,3 +1,25 @@
2016-04-19 Joanmarie Diggs <jdiggs@igalia.com>

[GTK] accessibility/gtk/entry-and-password.html is failing since r194847
https://bugs.webkit.org/show_bug.cgi?id=153062

Reviewed by Carlos Garcia Campos.

The changes in r194847 include using WebCore's rendering for the CapsLock indicator.
As a side effect, password inputs gained a TextControlInnerTextElement child from
the Shadow DOM. If we include that child in the accessibility tree, the child will
emit focus and text notifications that suggest the user is no longer in the control.
This can be especially problematic for screen reader users with key echo enabled
when typing in a password input. To fix this, prune TextControlInnerTextElement
children from the accessibility tree for ATK.

No new tests as existing coverage caught this regression. Also modified the
auto-fill-crash.html test whose expectations include the children count for
a text input.

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

2016-04-18 Brady Eidson <beidson@apple.com>

Modern IDB (Blob support): When reading Blobs from the database, grant the Networking process sandbox access to the files.
@@ -24,6 +24,7 @@
#include "HTMLElement.h"
#include "HTMLNames.h"
#include "RenderText.h"
#include "TextControlInnerElements.h"
#include <glib-object.h>

#if HAVE(ACCESSIBILITY)
@@ -96,6 +97,13 @@ AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesO
if (node && node->hasTagName(HTMLNames::spanTag) && !canSetFocusAttribute() && !hasAttributesRequiredForInclusion())
return IgnoreObject;

// If we include TextControlInnerTextElement children, changes to those children
// will result in focus and text notifications that suggest the user is no longer
// in the control. This can be especially problematic for screen reader users with
// key echo enabled when typing in a password input.
if (is<TextControlInnerTextElement>(node))
return IgnoreObject;

// Given a paragraph or div containing a non-nested anonymous block, WebCore
// ignores the paragraph or div and includes the block. We want the opposite:
// ATs are expecting accessible objects associated with textual elements. They

0 comments on commit 78b6316

Please sign in to comment.