Skip to content
Permalink
Browse files
http/tests/navigation/anchor-frames-same-origin.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=148690

Reviewed by Zalan Bujtas.

This is a temporary workaround for Bug 148690, until we have time
to investigate why scroll propagation does not work properly if
the frame is not already layed out when we scroll to the anchor.

This change updates the test to force a layout in the grandchild
frame before we scroll to the anchor. With this change, the test
is consistently passing when run on its own or after others.

* http/tests/navigation/resources/grandchild-with-anchor.html:

Canonical link: https://commits.webkit.org/166828@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Sep 2, 2015
1 parent 26af6a9 commit 7966b3a09a486f3da81829a80ebbbd6b59b832db
Showing 2 changed files with 22 additions and 0 deletions.
@@ -1,3 +1,20 @@
2015-09-02 Chris Dumez <cdumez@apple.com>

http/tests/navigation/anchor-frames-same-origin.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=148690

Reviewed by Zalan Bujtas.

This is a temporary workaround for Bug 148690, until we have time
to investigate why scroll propagation does not work properly if
the frame is not already layed out when we scroll to the anchor.

This change updates the test to force a layout in the grandchild
frame before we scroll to the anchor. With this change, the test
is consistently passing when run on its own or after others.

* http/tests/navigation/resources/grandchild-with-anchor.html:

2015-09-02 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r189241.
@@ -5,5 +5,10 @@
<!-- Spacer to make sure that the named anchor below requires scrolling -->
</div>
<a name="anchor1">This is an anchor point named "anchor1"</a>.
<script>
// Temporary workaround for https://bugs.webkit.org/show_bug.cgi?id=148690.
// Make sure layout is done before we scroll to the anchor.
document.body.offsetHeight;
</script>
</body>
</html>

0 comments on commit 7966b3a

Please sign in to comment.