Skip to content
Permalink
Browse files
userscripts/user-script-*-document.html tests are flaky on Windows

Reviewed by Brady Eidson.

WebCore:

In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData
if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length.

We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length.

This is tested by re-enabling user-script-plugin-document.html on Windows.

* plugins/PluginStream.cpp:
(WebCore::PluginStream::didReceiveData):

LayoutTests:

Unskip the user-script-plugin-document test because its issue is fixed.

* platform/win/Skipped:



Canonical link: https://commits.webkit.org/61336@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Brian Weinstein committed Oct 28, 2010
1 parent 7190f77 commit 79c85253b03a765604f1513a3236a64e3e20c368
Showing 4 changed files with 28 additions and 2 deletions.
@@ -1,3 +1,14 @@
2010-10-28 Brian Weinstein <bweinstein@apple.com>

Reviewed by Brady Eidson.

Part of <https://bugs.webkit.org/show_bug.cgi?id=45980>
userscripts/user-script-*-document.html tests are flaky on Windows

Unskip the user-script-plugin-document test because its issue is fixed.

* platform/win/Skipped:

2010-10-28 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Adler.
@@ -988,7 +988,6 @@ userscripts/user-style-top-frame-only.html
# https://bugs.webkit.org/show_bug.cgi?id=45980
userscripts/user-script-video-document.html
userscripts/user-script-audio-document.html
userscripts/user-script-plugin-document.html

# Directory upload is not enabled.
fast/forms/input-file-directory-upload.html
@@ -1,3 +1,20 @@
2010-10-28 Brian Weinstein <bweinstein@apple.com>

Reviewed by Brady Eidson.

Part of <https://bugs.webkit.org/show_bug.cgi?id=45980>
userscripts/user-script-*-document.html tests are flaky on Windows

In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData
if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length.

We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length.

This is tested by re-enabling user-script-plugin-document.html on Windows.

* plugins/PluginStream.cpp:
(WebCore::PluginStream::didReceiveData):

2010-10-28 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Adler.
@@ -413,7 +413,6 @@ void PluginStream::didReceiveResponse(NetscapePlugInStreamLoader* loader, const
void PluginStream::didReceiveData(NetscapePlugInStreamLoader* loader, const char* data, int length)
{
ASSERT(loader == m_loader);
ASSERT(length > 0);
ASSERT(m_streamState == StreamStarted);

// If the plug-in cancels the stream in deliverData it could be deleted,

0 comments on commit 79c8525

Please sign in to comment.