[chromium] Turn on the new Skia mask blur algorithm.

https://bugs.webkit.org/show_bug.cgi?id=103906 Reviewed by Adrienne Walker. Source/WebKit/chromium: * skia_webkit.gyp: LayoutTests: * platform/chromium/TestExpectations: Canonical link: https://commits.webkit.org/122182@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Dec 5, 2012 · 79dea4bc128a3c7a1becdfc705a620a56a1ebe1a · 79dea4b
1 parent 5448d4b
commit 79dea4bc128a3c7a1becdfc705a620a56a1ebe1a
Showing with 108 additions and 5 deletions.

+9 −0 LayoutTests/ChangeLog

+90 −3 LayoutTests/platform/chromium/TestExpectations

+9 −0 Source/WebKit/chromium/ChangeLog

+0 −2 Source/WebKit/chromium/skia_webkit.gyp
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,12 @@
+2012-12-04  Stephen White  <senorblanco@chromium.org>
+
+        [chromium] Turn on the new Skia mask blur algorithm.
+        https://bugs.webkit.org/show_bug.cgi?id=103906
+
+        Reviewed by Adrienne Walker.
+
+        * platform/chromium/TestExpectations:
+
 2012-12-04  Roger Fong  <roger_fong@apple.com>
 
         Unreviewed. Add Windows specific results for some tests following r136558 and r136560.

diff --git a/LayoutTests/platform/chromium/TestExpectations b/LayoutTests/platform/chromium/TestExpectations
@@ -86,7 +86,8 @@ webkit.org/b/24182 [ Debug ] fast/dom/css-delete-doc.html [ Pass Slow ]
 webkit.org/b/100272 [ Debug ] fast/media/w3c/test_media_queries.html [ Pass Slow ]
 webkit.org/b/70878 [ Linux Debug ] http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html [ Pass Slow ]
 webkit.org/b/102179 [ Win Debug ] platform/chromium/virtual/gpu/fast/hidpi/image-set-without-specified-width.html [ Pass Slow ]
-webkit.org/b/102463 [ Win Debug ] fast/forms/validation-message-appearance.html [ Pass ImageOnlyFailure ]
+# senorblanco:  uncomment this once tests have been rebaselined.
+# webkit.org/b/102463 [ Win Debug ] fast/forms/validation-message-appearance.html [ Pass ImageOnlyFailure ]
 webkit.org/b/102464 [ Debug ] fast/images/webgl-teximage2d.html [ Pass Timeout ]
 webkit.org/b/102464 [ Debug ] platform/chromium/virtual/deferred/fast/images/webgl-teximage2d.html [ Pass Timeout ]
 webkit.org/b/103744 svg/dom/viewspec-parser-7.html [ Pass Timeout ]
@@ -1295,7 +1296,7 @@ webkit.org/b/98569 svg/custom/gradient-with-1d-boundingbox.svg [ Failure Pass ]
 webkit.org/b/98569 svg/custom/recursive-gradient.svg [ Failure Pass ]
 
 # Failure: drawing a filled shadow for a fill=transparent rectangle.
-webkit.org/b/76557 [ Win Mac Android ] svg/custom/transform-with-shadow-and-gradient.svg [ ImageOnlyFailure ]
+webkit.org/b/76557 svg/custom/transform-with-shadow-and-gradient.svg [ ImageOnlyFailure ]
 
 webkit.org/b/78422 [ Android Linux Win ] svg/animations/animate-text-nested-transforms.html [ Failure ]
 
@@ -2183,7 +2184,7 @@ crbug.com/42875 sputnik [ WontFix ]
 crbug.com/43319 [ Android Linux Debug ] fast/forms/select-empty-option-height.html [ Pass Timeout ]
 
 # Not included in tests modified by 81992, but started failing on Android at same time:
-crbug.com/77494 [ Win7 Android ] fast/repaint/transform-replaced-shadows.html [ Failure ImageOnlyFailure ]
+crbug.com/77494 [ Android ] fast/repaint/transform-replaced-shadows.html [ Failure ImageOnlyFailure ]
 
 crbug.com/43890 [ Win ] http/tests/loading/basic.html [ Failure Pass ]
 
@@ -3764,6 +3765,92 @@ webkit.org/b/94492 [ Win ] css3/filters/custom/filter-repaint-custom-rotated.htm
 webkit.org/b/95581 http/tests/xmlhttprequest/zero-length-response.html [ Pass Timeout ]
 webkit.org/b/95581 http/tests/misc/javascript-url-stop-loaders.html [ Pass Timeout ]
 
+# Will need rebaselines after SK_DISABLE_SEPARABLE_MASK_BLUR is removed.
+webkit.org/b/103906 [ Win Mac Linux ] compositing/culling/scrolled-within-boxshadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 compositing/culling/translated-boxshadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 compositing/culling/unscrolled-within-boxshadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] compositing/geometry/clipping-foreground.html [ ImageOnlyFailure ]
+webkit.org/b/103906 compositing/geometry/foreground-layer.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] compositing/iframes/composited-iframe-alignment.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] compositing/masks/masked-ancestor.html [ ImageOnlyFailure ]
+webkit.org/b/103906 compositing/shadows/shadow-drawing.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/borders/border-radius-constraints.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/borders/border-radius-split-inline.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/borders/mixed-border-styles-radius.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/basic-shadows.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/box-shadow-clipped-slices.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/box-shadow-radius.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/box-shadow-transformed.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/inset-box-shadow-radius.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/inset-box-shadows.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/inset.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/scaled-box-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/shadow-buffer-partial.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/shadow-tiling-artifact.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/box-shadow/single-pixel-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Linux ] fast/css/background-clip-radius-values.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/css/box-shadow-and-border-radius.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] fast/css/color-correction-on-box-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] fast/css/color-correction-on-text-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/css/shadow-multiple.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/forms/validation-message-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/multicol/shadow-breaking.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/repaint/box-shadow-h.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/repaint/box-shadow-v.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/repaint/moving-shadow-on-path.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/repaint/shadow-multiple-vertical.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/text/shadow-translucent-fill.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/text/stroking-decorations.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/text/stroking.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/transforms/shadows.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/writing-mode/box-shadow-horizontal-bt.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/writing-mode/box-shadow-vertical-lr.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/writing-mode/box-shadow-vertical-rl.html [ ImageOnlyFailure ]
+webkit.org/b/103906 fast/writing-mode/english-lr-text.html [ ImageOnlyFailure ]
+webkit.org/b/103906 ietestcenter/css3/text/textshadow-001.htm [ ImageOnlyFailure ]
+webkit.org/b/103906 ietestcenter/css3/text/textshadow-002.htm [ ImageOnlyFailure ]
+webkit.org/b/103906 ietestcenter/css3/text/textshadow-003.htm [ ImageOnlyFailure ]
+webkit.org/b/103906 ietestcenter/css3/text/textshadow-004.htm [ ImageOnlyFailure ]
+webkit.org/b/103906 ietestcenter/css3/text/textshadow-010.htm [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/calendar-picker/month-picker-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/culling/scrolled-within-boxshadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/culling/translated-boxshadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/culling/unscrolled-within-boxshadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/geometry/foreground-layer.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/masks/masked-ancestor.html [ ImageOnlyFailure ]
+webkit.org/b/103906 platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing.html [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/circle-in-mask-with-shadow.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/path-with-shadow.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/shadow-and-opacity.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/shadow-with-large-radius.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/shadow-with-negative-offset.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/stars-with-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/text-gradient-shadow.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/css/text-shadow-multiple.xhtml [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/custom/repaint-shadow.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 svg/filters/shadow-on-rect-with-filter.svg [ ImageOnlyFailure ]
+webkit.org/b/103906 transitions/svg-text-shadow-transition.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Mac ] fast/canvas/fillText-shadow.html [ Failure ]
+webkit.org/b/103906 [ Mac ] platform/chromium/virtual/gpu/fast/canvas/fillText-shadow.html [ Failure ]
+webkit.org/b/103906 [ Win Mac Linux ] fast/repaint/shadow-multiple-horizontal.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] fast/repaint/shadow-multiple-strict-horizontal.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] fast/repaint/shadow-multiple-strict-vertical.html [ ImageOnlyFailure ]
+webkit.org/b/103906 [ Win Mac Linux ] fast/repaint/transform-replaced-shadows.html [ ImageOnlyFailure ]
+
+
 # Flaky timeouts.
 webkit.org/b/99734 [ Mac ] http/tests/xmlhttprequest/request-encoding2.html [ Pass Timeout ]
 

diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog
@@ -1,3 +1,12 @@
+2012-12-04  Stephen White  <senorblanco@chromium.org>
+
+        [chromium] Turn on the new Skia mask blur algorithm.
+        https://bugs.webkit.org/show_bug.cgi?id=103906
+
+        Reviewed by Adrienne Walker.
+
+        * skia_webkit.gyp:
+
 2012-12-04  Stephen White  <senorblanco@chromium.org>
 
         Unreviewed.  Rolled DEPS.

diff --git a/Source/WebKit/chromium/skia_webkit.gyp b/Source/WebKit/chromium/skia_webkit.gyp
@@ -46,8 +46,6 @@
           'SK_DISABLE_DITHER_32BIT_GRADIENT',
 
           'SK_DISABLE_DASHING_OPTIMIZATION',
-
-          'SK_DISABLE_SEPARABLE_MASK_BLUR',
         ],
       },
     },