Skip to content
Permalink
Browse files
Remove support for NPAPI plugins in WebView
https://bugs.webkit.org/show_bug.cgi?id=224449

Patch by Alex Christensen <achristensen@webkit.org> on 2021-04-13
Reviewed by Chris Dumez.

Source/WebKitLegacy/mac:

* WebView/WebPreferences.mm:
(-[WebPreferences setPlugInsEnabled:]):

Source/WTF:

* Scripts/Preferences/WebPreferences.yaml:

Tools:

Keep them on in tests until we remove the code.

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/236476@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Alex Christensen authored and webkit-commit-queue committed Apr 13, 2021
1 parent a785e9c commit 7b31fcc13567dcf663e2eec32908e9bed464f5a5
Showing 6 changed files with 35 additions and 3 deletions.
@@ -1,3 +1,12 @@
2021-04-13 Alex Christensen <achristensen@webkit.org>

Remove support for NPAPI plugins in WebView
https://bugs.webkit.org/show_bug.cgi?id=224449

Reviewed by Chris Dumez.

* Scripts/Preferences/WebPreferences.yaml:

2021-04-13 Chris Dumez <cdumez@apple.com>

Make MemoryPressureHandler::isUnderMemoryPressure() return true for 2 seconds after a simulated warning
@@ -1720,7 +1720,7 @@ PluginsEnabled:
webcoreOnChange: pluginsEnabledChanged
defaultValue:
WebKitLegacy:
default: true
default: false
WebKit:
default: false
WebCore:
@@ -1,3 +1,13 @@
2021-04-13 Alex Christensen <achristensen@webkit.org>

Remove support for NPAPI plugins in WebView
https://bugs.webkit.org/show_bug.cgi?id=224449

Reviewed by Chris Dumez.

* WebView/WebPreferences.mm:
(-[WebPreferences setPlugInsEnabled:]):

2021-04-12 Peng Liu <peng.liu6@apple.com>

Fix some issues hidden by unified build
@@ -900,7 +900,8 @@ - (BOOL)arePlugInsEnabled

- (void)setPlugInsEnabled:(BOOL)flag
{
[self _setBoolValue: flag forKey: WebKitPluginsEnabledPreferenceKey];
if (flag)
RELEASE_LOG_FAULT(Plugins, "Application attempted to enable WebView NPAPI plug ins, which are no longer supported");
}

- (BOOL)allowsAnimatedImages
@@ -1,3 +1,15 @@
2021-04-13 Alex Christensen <achristensen@webkit.org>

Remove support for NPAPI plugins in WebView
https://bugs.webkit.org/show_bug.cgi?id=224449

Reviewed by Chris Dumez.

Keep them on in tests until we remove the code.

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

2021-04-13 Alex Christensen <achristensen@webkit.org>

Remove support for NPAPI plugins in WKWebView
@@ -63,6 +63,7 @@ const TestFeatures& TestOptions::defaults()
static TestFeatures features;
if (features.boolWebPreferenceFeatures.empty()) {
features.boolWebPreferenceFeatures = {
{ "PluginsEnabled", true },
#if PLATFORM(COCOA)
// These are non-experimental WebPreference values that must always be set as they
// differ from the default set in the WebPreferences*.yaml configuration.
@@ -154,7 +155,6 @@ const TestFeatures& TestOptions::defaults()
{ "ModernMediaControlsEnabled", true },
{ "NeedsStorageAccessFromFileURLsQuirk", false },
{ "OverscrollBehaviorEnabled", true },
{ "PluginsEnabled", true },
{ "PrivateClickMeasurementEnabled", false },
{ "RequestIdleCallbackEnabled", false },
{ "ResizeObserverEnabled", false },

0 comments on commit 7b31fcc

Please sign in to comment.