Skip to content
Permalink
Browse files
2010-11-19 Zalan Bujtas <zbujtas@gmail.com>
        Reviewed by Andreas Kling.

        WebUIClient::createNewPage() expects a retained WKPageRef.
        https://bugs.webkit.org/show_bug.cgi?id=48549

        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_createNewPage):

Canonical link: https://commits.webkit.org/62930@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue committed Nov 20, 2010
1 parent 3094049 commit 7c2108372c8a62f56e8e24ed564b5e0d3fce49db
Showing with 14 additions and 1 deletion.
  1. +10 −0 WebKit2/ChangeLog
  2. +4 −1 WebKit2/UIProcess/API/qt/ClientImpl.cpp
@@ -1,3 +1,13 @@
2010-11-19 Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Andreas Kling.

WebUIClient::createNewPage() expects a retained WKPageRef.
https://bugs.webkit.org/show_bug.cgi?id=48549

* UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_createNewPage):

2010-11-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.
@@ -26,6 +26,7 @@
#include <qwkpage.h>
#include <qwkpage_p.h>
#include <WKFrame.h>
#include <WKType.h>

using namespace WebKit;

@@ -143,8 +144,10 @@ WKPageRef qt_wk_createNewPage(WKPageRef page, WKDictionaryRef features, WKEventM
if (!createNewPageFn)
return 0;

if (QWKPage* newPage = createNewPageFn(wkPage))
if (QWKPage* newPage = createNewPageFn(wkPage)) {
WKRetain(newPage->pageRef());
return newPage->pageRef();
}

return 0;
}

0 comments on commit 7c21083

Please sign in to comment.