Skip to content
Permalink
Browse files
range-hit-test-with-padding.html fails unless subpixel layout is on
https://bugs.webkit.org/show_bug.cgi?id=94585

Reviewed by Kent Tamura.

Ports without subpixel layout didn't exactly match the result, because slider thumb width is an odd number and we are dividing it by two.

* fast/forms/range/range-hit-test-with-padding-expected.txt:
* fast/forms/range/range-hit-test-with-padding.html: Adjust the max so it snaps to the step in the middle.


Canonical link: https://commits.webkit.org/112484@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
keishi committed Aug 22, 2012
1 parent 4adbfaa commit 7ceb4543a859d80dd4c9f56822435ecf568e1ae7
Showing 3 changed files with 16 additions and 4 deletions.
@@ -1,3 +1,15 @@
2012-08-21 Keishi Hattori <keishi@webkit.org>

range-hit-test-with-padding.html fails unless subpixel layout is on
https://bugs.webkit.org/show_bug.cgi?id=94585

Reviewed by Kent Tamura.

Ports without subpixel layout didn't exactly match the result, because slider thumb width is an odd number and we are dividing it by two.

* fast/forms/range/range-hit-test-with-padding-expected.txt:
* fast/forms/range/range-hit-test-with-padding.html: Adjust the max so it snaps to the step in the middle.

2012-08-21 Julien Chaffraix <jchaffraix@webkit.org>

Crash in RenderTableSection::setCellLogicalWidths
@@ -1,6 +1,6 @@
Clicking middle of input type=range with padding should set the value to middle.

PASS input.value is "500"
PASS input.value is "25"
PASS successfullyParsed is true

TEST COMPLETE
@@ -6,7 +6,7 @@
<body>
<p id="description">Clicking middle of input type=range with padding should set the value to middle.</p>
<div id="console"></div>
<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
<input id="input" type=range min=0 max=50 step=1 value="0" style="width: 100px; padding: 0 40px;">
<script>
var input = document.getElementById("input");
function clickSlider(offsetLeft) {
@@ -16,8 +16,8 @@
eventSender.mouseUp();
}

clickSlider(70); // left padding (20px) + middle (50px)
shouldBe('input.value', '"500"');
clickSlider(90); // left padding (40px) + middle (50px)
shouldBe('input.value', '"25"');

</script>

0 comments on commit 7ceb454

Please sign in to comment.