Skip to content
Permalink
Browse files
Drop [UsePointersEvenForNonNullableObjectArguments] from DOMURL
https://bugs.webkit.org/show_bug.cgi?id=156797

Reviewed by Youenn Fablet.

* html/DOMURL.cpp:
(WebCore::DOMURL::create):
* html/DOMURL.h:
* html/DOMURL.idl:

Canonical link: https://commits.webkit.org/174951@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Apr 21, 2016
1 parent 5239525 commit 7e053c4067d8c37ca694212e430d874aae85d505
Showing with 16 additions and 6 deletions.
  1. +12 −0 Source/WebCore/ChangeLog
  2. +2 −3 Source/WebCore/html/DOMURL.cpp
  3. +1 −1 Source/WebCore/html/DOMURL.h
  4. +1 −2 Source/WebCore/html/DOMURL.idl
@@ -1,3 +1,15 @@
2016-04-21 Chris Dumez <cdumez@apple.com>

Drop [UsePointersEvenForNonNullableObjectArguments] from DOMURL
https://bugs.webkit.org/show_bug.cgi?id=156797

Reviewed by Youenn Fablet.

* html/DOMURL.cpp:
(WebCore::DOMURL::create):
* html/DOMURL.h:
* html/DOMURL.idl:

2016-04-21 Claudio Saavedra <csaavedra@igalia.com>

[GTK][EFL] Move non-glib/gtk platform implementations out of platform/gtk
@@ -43,10 +43,9 @@ Ref<DOMURL> DOMURL::create(const String& url, const String& base, ExceptionCode&
return adoptRef(*new DOMURL(url, base, ec));
}

Ref<DOMURL> DOMURL::create(const String& url, const DOMURL* base, ExceptionCode& ec)
Ref<DOMURL> DOMURL::create(const String& url, const DOMURL& base, ExceptionCode& ec)
{
ASSERT(base);
return adoptRef(*new DOMURL(url, *base, ec));
return adoptRef(*new DOMURL(url, base, ec));
}

Ref<DOMURL> DOMURL::create(const String& url, ExceptionCode& ec)
@@ -44,7 +44,7 @@ class DOMURL : public RefCounted<DOMURL>, public URLUtils<DOMURL> {

public:
static Ref<DOMURL> create(const String& url, const String& base, ExceptionCode&);
static Ref<DOMURL> create(const String& url, const DOMURL* base, ExceptionCode&);
static Ref<DOMURL> create(const String& url, const DOMURL& base, ExceptionCode&);
static Ref<DOMURL> create(const String& url, ExceptionCode&);

URL href() const { return m_url; }
@@ -30,14 +30,13 @@
Constructor(DOMString url, DOMString base),
Constructor(DOMString url, DOMURL base),
ConstructorRaisesException,
UsePointersEvenForNonNullableObjectArguments,
JSGenerateToNativeObject,
JSGenerateToJSObject,
InterfaceName=URL,
ImplementationLacksVTable,
ExportMacro=WEBCORE_EXPORT,
] interface DOMURL {
[CallWith=ScriptExecutionContext] static DOMString? createObjectURL(Blob? blob);
[CallWith=ScriptExecutionContext] static DOMString? createObjectURL(Blob? blob); // FIXME: The return value and the parameter should not be nullable.
[CallWith=ScriptExecutionContext] static void revokeObjectURL(DOMString url);
};

0 comments on commit 7e053c4

Please sign in to comment.