Skip to content
Permalink
Browse files
[GPUP] RemoteAudioSession::setPreferredBufferSize() does not change i…
…ts preferredBufferSize

https://bugs.webkit.org/show_bug.cgi?id=228720

Reviewed by Jer Noble.

Source/WebKit:

`RemoteAudioSession` should update its `preferredBufferSize` in
`setPreferredBufferSize()`. Otherwise, the `preferredBufferSize`
will become inconsistent with the value in the GPU process.

No new tests. Fix API test failures.

* WebProcess/GPU/media/RemoteAudioSession.cpp:
(WebKit::RemoteAudioSession::setPreferredBufferSize):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(TEST_F):


Canonical link: https://commits.webkit.org/240198@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
pliu6 committed Aug 3, 2021
1 parent ab6fc92 commit 7f632b6b12f5aa036b62e4fe16b2127235708aa7
Showing 4 changed files with 33 additions and 6 deletions.
@@ -1,3 +1,19 @@
2021-08-02 Peng Liu <peng.liu6@apple.com>

[GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
https://bugs.webkit.org/show_bug.cgi?id=228720

Reviewed by Jer Noble.

`RemoteAudioSession` should update its `preferredBufferSize` in
`setPreferredBufferSize()`. Otherwise, the `preferredBufferSize`
will become inconsistent with the value in the GPU process.

No new tests. Fix API test failures.

* WebProcess/GPU/media/RemoteAudioSession.cpp:
(WebKit::RemoteAudioSession::setPreferredBufferSize):

2021-08-02 Kate Cheney <katherine_cheney@apple.com>

[App Privacy Report] Domains are deleted for ephemeral website data stores
@@ -109,6 +109,7 @@ void RemoteAudioSession::setCategory(CategoryType type, RouteSharingPolicy polic

void RemoteAudioSession::setPreferredBufferSize(size_t size)
{
configuration().preferredBufferSize = size;
ensureConnection().send(Messages::RemoteAudioSessionProxy::SetPreferredBufferSize(size), { });
}

@@ -1,3 +1,13 @@
2021-08-02 Peng Liu <peng.liu6@apple.com>

[GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
https://bugs.webkit.org/show_bug.cgi?id=228720

Reviewed by Jer Noble.

* TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(TEST_F):

2021-08-02 Alex Christensen <achristensen@webkit.org>

Don't change invalid baseURLs from loadData or loadHTMLString to about:blank
@@ -79,32 +79,32 @@ void runPlayingTestWithPageNamed(NSString* name, double expectedAudioBufferSize)
EXPECT_EQ(512, preferredAudioBufferSize());
}

TEST_F(PreferredAudioBufferSize, DISABLED_AudioElement)
TEST_F(PreferredAudioBufferSize, AudioElement)
{
runPlayingTestWithPageNamed(@"audio-only", 4096);
}

TEST_F(PreferredAudioBufferSize, DISABLED_WebAudio)
TEST_F(PreferredAudioBufferSize, WebAudio)
{
runPlayingTestWithPageNamed(@"web-audio-only", 128);
}

TEST_F(PreferredAudioBufferSize, DISABLED_VideoOnly)
TEST_F(PreferredAudioBufferSize, VideoOnly)
{
runPlayingTestWithPageNamed(@"video-without-audio", 4096);
}

TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudio)
TEST_F(PreferredAudioBufferSize, VideoWithAudio)
{
runPlayingTestWithPageNamed(@"video-with-audio", 4096);
}

TEST_F(PreferredAudioBufferSize, DISABLED_AudioWithWebAudio)
TEST_F(PreferredAudioBufferSize, AudioWithWebAudio)
{
runPlayingTestWithPageNamed(@"audio-with-web-audio", 128);
}

TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudioAndWebAudio)
TEST_F(PreferredAudioBufferSize, VideoWithAudioAndWebAudio)
{
runPlayingTestWithPageNamed(@"video-with-audio-and-web-audio", 128);
}

0 comments on commit 7f632b6

Please sign in to comment.