Skip to content
Permalink
Browse files
2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        * WebKit.pri: Turn on warnings for the GCC compiler
2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        No new tests as there is no functional change.

        * platform/image-decoders/qt/RGBA32BufferQt.cpp:
        (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder
        initialization list to fix compiler warnings.

2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate): Reorder initialization list
        to fix compiler warnings.
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.
2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        * DumpRenderTree/qt/main.cpp:
        (crashHandler): Mark function NO_RETURN

Canonical link: https://commits.webkit.org/41825@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Nov 1, 2009
1 parent e66aca1 commit 804d45ed189f9d59db1a1e7cd25f5c976eb3c9da
Showing 9 changed files with 55 additions and 8 deletions.
@@ -1,3 +1,12 @@
2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

* WebKit.pri: Turn on warnings for the GCC compiler

2009-10-30 Adam Barth <abarth@webkit.org>

Reviewed by Mark Rowe.
@@ -1,3 +1,17 @@
2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

No new tests as there is no functional change.

* platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::RGBA32Buffer): Reorder
initialization list to fix compiler warnings.


2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.
@@ -34,9 +34,9 @@
namespace WebCore {

RGBA32Buffer::RGBA32Buffer()
: m_status(FrameEmpty)
, m_hasAlpha(false)
: m_hasAlpha(false)
, m_size()
, m_status(FrameEmpty)
, m_duration(0)
, m_disposalMethod(DisposeNotSpecified)
{
@@ -47,8 +47,7 @@ BASE_DIR = $$PWD
INCLUDEPATH += $$PWD/WebKit/qt/Api

CONFIG -= warn_on
*-g++*:QMAKE_CXXFLAGS += -Wreturn-type -fno-strict-aliasing
#QMAKE_CXXFLAGS += -Wall -Wno-undef -Wno-unused-parameter
*-g++*:QMAKE_CXXFLAGS += -Wall -Wreturn-type -fno-strict-aliasing -Wcast-align -Wchar-subscripts -Wformat-security -Wreturn-type -Wno-unused-parameter -Wno-sign-compare -Wno-switch -Wno-switch-enum -Wundef -Wmissing-noreturn -Winit-self

# Enable GNU compiler extensions to the ARM compiler for all Qt ports using RVCT
symbian|*-armcc {
@@ -266,11 +266,11 @@ QWebPagePrivate::QWebPagePrivate(QWebPage *qq)
#if QT_VERSION < 0x040600
, view(0)
#endif
, clickCausedFocus(false)
, viewportSize(QSize(0, 0))
, inspectorFrontend(0)
, inspector(0)
, inspectorIsInternalOnly(false)
, viewportSize(QSize(0, 0))
, clickCausedFocus(false)
{
WebCore::InitializeLoggingChannelsIfNecessary();
JSC::initializeThreading();
@@ -1,3 +1,16 @@
2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Reorder initialization list
to fix compiler warnings.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.

2009-10-30 Evan Stade <estade@chromium.org>

Reviewed by David Levin.
@@ -145,9 +145,9 @@ namespace WebCore
FrameLoaderClientQt::FrameLoaderClientQt()
: m_frame(0)
, m_webFrame(0)
, m_firstData(false)
, m_pluginView(0)
, m_hasSentResponseToPlugin(false)
, m_firstData(false)
, m_loadError (ResourceError())
{
}
@@ -1,3 +1,13 @@
2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

* DumpRenderTree/qt/main.cpp:
(crashHandler): Mark function NO_RETURN

2009-11-01 Jessie Berlin <jberlin@webkit.org>

Adding myself to the committers list.
@@ -29,6 +29,8 @@

#include "DumpRenderTree.h"

#include <wtf/AlwaysInline.h>

#include <qstringlist.h>
#include <qapplication.h>
#include <qurl.h>
@@ -86,7 +88,7 @@ QString get_backtrace() {
return s;
}

static void crashHandler(int sig)
static NO_RETURN void crashHandler(int sig)
{
fprintf(stderr, "%s\n", strsignal(sig));
fprintf(stderr, "%s\n", get_backtrace().toLatin1().constData());

0 comments on commit 804d45e

Please sign in to comment.