Skip to content
Permalink
Browse files
video.currentSrc should not be reset when a new load errors
https://bugs.webkit.org/show_bug.cgi?id=225451

Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-17
Reviewed by Jer Noble.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-currentSrc-expected.txt:
Covered by existing test which was previously failing.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):

Media test removed since this condition is already covered by the above WPT test.
* LayoutTests/media/video-currentsrc-cleared.html: Removed.
* LayoutTests/media/video-currentsrc-cleared-expected.txt: Removed.

Canonical link: https://commits.webkit.org/251654@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youssefsoli authored and webkit-commit-queue committed Jun 17, 2022
1 parent 209bda5 commit 822707497bf075a52798f9879d7835c9b175edc2
Showing 4 changed files with 1 addition and 48 deletions.
@@ -1,3 +1,3 @@

FAIL Test currentSrc behaviour in various playback scenarios assert_true: Not reset when a new load errors expected true got false
PASS Test currentSrc behaviour in various playback scenarios

This file was deleted.

This file was deleted.

@@ -1183,7 +1183,6 @@ void HTMLMediaElement::prepareForLoad()
m_haveFiredLoadedData = false;
m_completelyLoaded = false;
m_havePreparedToPlay = false;
setCurrentSrc(URL());

#if ENABLE(WIRELESS_PLAYBACK_TARGET)
m_failedToPlayToWirelessTarget = false;

0 comments on commit 8227074

Please sign in to comment.