Skip to content
Permalink
Browse files
Modernize QualifiedName by wrapping gNameCache in a function and usin…
…g more early exits

https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Address Ben's review comment.

* dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):


Canonical link: https://commits.webkit.org/136554@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rniwa committed Jul 15, 2013
1 parent e4d62b0 commit 8272fa22c741aca75328678f1a4d4f9061d75a72
Showing with 13 additions and 5 deletions.
  1. +12 −0 Source/WebCore/ChangeLog
  2. +1 −5 Source/WebCore/dom/QualifiedName.cpp
@@ -1,3 +1,15 @@
2013-07-14 Ryosuke Niwa <rniwa@webkit.org>

Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Address Ben's review comment.

* dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):

2013-07-14 Ryosuke Niwa <rniwa@webkit.org>

HTMLTextFormControlElement::valueWithHardLineBreaks shouldn't upconvert 8-bit string
@@ -117,11 +117,7 @@ String QualifiedName::toString() const
if (!hasPrefix())
return localName();

StringBuilder result;
result.append(prefix());
result.append(':');
result.append(localName());
return result.toString();
return prefix() + ':' + localName();
}

// Global init routines

0 comments on commit 8272fa2

Please sign in to comment.