Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
MapData and WeakMapData don't need to be objects
https://bugs.webkit.org/show_bug.cgi?id=121167 Patch by Sam Weinig <sam@webkit.org> on 2013-09-11 Reviewed by Geoffrey Garen. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::visitChildren): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::mapStructure): Remove MapData and WeakMapData structures (they moved to VM with other non-object Structures). * runtime/JSMap.cpp: (JSC::JSMap::finishCreation): * runtime/JSMap.h: (JSC::JSMap::create): * runtime/JSSet.cpp: (JSC::JSSet::finishCreation): * runtime/JSSet.h: (JSC::JSSet::create): * runtime/JSWeakMap.cpp: (JSC::JSWeakMap::finishCreation): * runtime/JSWeakMap.h: (JSC::JSWeakMap::create): Update to not pass a global object to the MapData or WeakMapData Structure. * runtime/MapData.cpp: (JSC::MapData::MapData): * runtime/MapData.h: (JSC::MapData::create): (JSC::MapData::createStructure): * runtime/WeakMapData.cpp: (JSC::WeakMapData::WeakMapData): (JSC::WeakMapData::set): Change to take a VM rather than a CallFrame, as that it all it needs. * runtime/WeakMapData.h: (JSC::WeakMapData::create): (JSC::WeakMapData::createStructure): Instead of inheriting from JSDestructibleObject, inherit from JSCell and mark self as needing destruction and having an immortal structure. * runtime/VM.cpp: (JSC::VM::VM): * runtime/VM.h: Add MapData and WeakMapData Structures. * runtime/WeakMapPrototype.cpp: (JSC::protoFuncWeakMapSet): Pass a VM rather than an ExecState. Canonical link: https://commits.webkit.org/139116@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
110 additions
and 67 deletions.
- +51 −0 Source/JavaScriptCore/ChangeLog
- +0 −9 Source/JavaScriptCore/runtime/JSGlobalObject.cpp
- +0 −5 Source/JavaScriptCore/runtime/JSGlobalObject.h
- +2 −2 Source/JavaScriptCore/runtime/JSMap.cpp
- +2 −3 Source/JavaScriptCore/runtime/JSMap.h
- +2 −2 Source/JavaScriptCore/runtime/JSSet.cpp
- +2 −2 Source/JavaScriptCore/runtime/JSSet.h
- +2 −2 Source/JavaScriptCore/runtime/JSWeakMap.cpp
- +8 −5 Source/JavaScriptCore/runtime/JSWeakMap.h
- +3 −3 Source/JavaScriptCore/runtime/MapData.cpp
- +11 −10 Source/JavaScriptCore/runtime/MapData.h
- +5 −1 Source/JavaScriptCore/runtime/VM.cpp
- +2 −0 Source/JavaScriptCore/runtime/VM.h
- +6 −7 Source/JavaScriptCore/runtime/WeakMapData.cpp
- +13 −15 Source/JavaScriptCore/runtime/WeakMapData.h
- +1 −1 Source/JavaScriptCore/runtime/WeakMapPrototype.cpp
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.