Skip to content
Permalink
Browse files
Web Inspector: Sources: Scope Chain sidebar panel is stripping repeat…
…ing whitespace from strings

https://bugs.webkit.org/show_bug.cgi?id=227234

Reviewed by Devin Rousso.

String and Regular Expression values in Object Trees were having `white-space: nowrap;` applied to them, which
was redundant because `white-space: pre;` was already defined for `.formatted-string` and `.formatted-regexp`,
which makes sure that the text does not wrap unless it contains a newline, and these previews have newlines
replaced with a Unicode symbol to visually represent a newline without breaking to a new line.

* UserInterface/Views/ObjectTreeView.css:
(.object-tree-property :matches(.formatted-string, .formatted-regexp)): Deleted.


Canonical link: https://commits.webkit.org/239170@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
patrickangle committed Jun 25, 2021
1 parent cf05803 commit 82b8699d582935194a3ce0f679b9ec05188e0143
Showing 2 changed files with 15 additions and 4 deletions.
@@ -1,3 +1,18 @@
2021-06-25 Patrick Angle <pangle@apple.com>

Web Inspector: Sources: Scope Chain sidebar panel is stripping repeating whitespace from strings
https://bugs.webkit.org/show_bug.cgi?id=227234

Reviewed by Devin Rousso.

String and Regular Expression values in Object Trees were having `white-space: nowrap;` applied to them, which
was redundant because `white-space: pre;` was already defined for `.formatted-string` and `.formatted-regexp`,
which makes sure that the text does not wrap unless it contains a newline, and these previews have newlines
replaced with a Unicode symbol to visually represent a newline without breaking to a new line.

* UserInterface/Views/ObjectTreeView.css:
(.object-tree-property :matches(.formatted-string, .formatted-regexp)): Deleted.

2021-06-14 Patrick Angle <pangle@apple.com>

[REGRESSION: r276616] Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._setupCodeMirror.getValue')
@@ -139,7 +139,3 @@
margin-inline-start: 2px;
vertical-align: -4px;
}

.object-tree-property :matches(.formatted-string, .formatted-regexp) {
white-space: nowrap;
}

0 comments on commit 82b8699

Please sign in to comment.